You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Donal Lafferty <do...@citrix.com> on 2013/07/05 13:56:14 UTC
Review Request 12277: Add VHDX image support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12277/
-----------------------------------------------------------
Review request for cloudstack and edison su.
Repository: cloudstack-git
Description
-------
Add VHDX image support, which is missing from DiskFormat class, revised ImageFormat interface, StorageManager implementation, and the application component spec.
NB: applicationContext.xml.in can only be checked at runtime. A non-Hyper-V user should verify that it does not break anything.
Diffs
-----
client/tomcatconf/applicationContext.xml.in 14255c1e7a50719757ffa4f3d6f27eaeacfde917
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/DiskFormat.java 6be7a6bb49eb534b56cb9da9c88da5ffb7d00fa4
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/VHDX.java PRE-CREATION
engine/storage/src/org/apache/cloudstack/storage/image/format/VHDX.java PRE-CREATION
server/src/com/cloud/storage/StorageManagerImpl.java d9ef853a743c1bfbb1e8a3aa911f1f857985b15a
Diff: https://reviews.apache.org/r/12277/diff/
Testing
-------
Compiles and runs when using Hyper-V plugin.
Has not been run in non-Hyper-V scenarios.
Thanks,
Donal Lafferty
Re: Review Request 12277: Add VHDX image support
Posted by Devdeep Singh <de...@citrix.com>.
> On July 18, 2013, 1:36 p.m., Devdeep Singh wrote:
> > Committed to master with commit id 876a7b3361a17bc16b1342fdebbff0f0306674a6.
Kindly close the request.
- Devdeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12277/#review23378
-----------------------------------------------------------
On July 15, 2013, 9:12 a.m., Donal Lafferty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12277/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 9:12 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and edison su.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add VHDX image support, which is missing from DiskFormat class, revised ImageFormat interface, StorageManager implementation, and the application component spec.
>
> NB: applicationContext.xml.in can only be checked at runtime. A non-Hyper-V user should verify that it does not break anything.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 14255c1e7a50719757ffa4f3d6f27eaeacfde917
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/DiskFormat.java 6be7a6bb49eb534b56cb9da9c88da5ffb7d00fa4
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/VHDX.java PRE-CREATION
> engine/storage/src/org/apache/cloudstack/storage/image/format/VHDX.java PRE-CREATION
> server/src/com/cloud/storage/StorageManagerImpl.java d9ef853a743c1bfbb1e8a3aa911f1f857985b15a
>
> Diff: https://reviews.apache.org/r/12277/diff/
>
>
> Testing
> -------
>
> Compiles and runs when using Hyper-V plugin.
>
> Has not been run in non-Hyper-V scenarios.
>
>
> Thanks,
>
> Donal Lafferty
>
>
Re: Review Request 12277: Add VHDX image support
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12277/#review23378
-----------------------------------------------------------
Ship it!
Committed to master with commit id 876a7b3361a17bc16b1342fdebbff0f0306674a6.
- Devdeep Singh
On July 15, 2013, 9:12 a.m., Donal Lafferty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12277/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 9:12 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and edison su.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add VHDX image support, which is missing from DiskFormat class, revised ImageFormat interface, StorageManager implementation, and the application component spec.
>
> NB: applicationContext.xml.in can only be checked at runtime. A non-Hyper-V user should verify that it does not break anything.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 14255c1e7a50719757ffa4f3d6f27eaeacfde917
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/DiskFormat.java 6be7a6bb49eb534b56cb9da9c88da5ffb7d00fa4
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/VHDX.java PRE-CREATION
> engine/storage/src/org/apache/cloudstack/storage/image/format/VHDX.java PRE-CREATION
> server/src/com/cloud/storage/StorageManagerImpl.java d9ef853a743c1bfbb1e8a3aa911f1f857985b15a
>
> Diff: https://reviews.apache.org/r/12277/diff/
>
>
> Testing
> -------
>
> Compiles and runs when using Hyper-V plugin.
>
> Has not been run in non-Hyper-V scenarios.
>
>
> Thanks,
>
> Donal Lafferty
>
>
Re: Review Request 12277: Add VHDX image support
Posted by Donal Lafferty <do...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12277/
-----------------------------------------------------------
(Updated July 15, 2013, 9:12 a.m.)
Review request for cloudstack, Devdeep Singh and edison su.
Repository: cloudstack-git
Description
-------
Add VHDX image support, which is missing from DiskFormat class, revised ImageFormat interface, StorageManager implementation, and the application component spec.
NB: applicationContext.xml.in can only be checked at runtime. A non-Hyper-V user should verify that it does not break anything.
Diffs
-----
client/tomcatconf/applicationContext.xml.in 14255c1e7a50719757ffa4f3d6f27eaeacfde917
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/DiskFormat.java 6be7a6bb49eb534b56cb9da9c88da5ffb7d00fa4
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/VHDX.java PRE-CREATION
engine/storage/src/org/apache/cloudstack/storage/image/format/VHDX.java PRE-CREATION
server/src/com/cloud/storage/StorageManagerImpl.java d9ef853a743c1bfbb1e8a3aa911f1f857985b15a
Diff: https://reviews.apache.org/r/12277/diff/
Testing
-------
Compiles and runs when using Hyper-V plugin.
Has not been run in non-Hyper-V scenarios.
Thanks,
Donal Lafferty