You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ep...@apache.org on 2006/01/17 04:25:08 UTC
svn commit: r369655 - in
/maven/repository-manager/trunk/maven-repository-indexer/src/test:
java/org/apache/maven/repository/indexing/MetadataRepositoryIndexingTest.java
repository/test/maven-metadata.xml
Author: epunzalan
Date: Mon Jan 16 19:24:59 2006
New Revision: 369655
URL: http://svn.apache.org/viewcvs?rev=369655&view=rev
Log:
PR: MRM-35
Submitted by: Maria Odea Ching
Added more unit tests
Added:
maven/repository-manager/trunk/maven-repository-indexer/src/test/repository/test/maven-metadata.xml
Modified:
maven/repository-manager/trunk/maven-repository-indexer/src/test/java/org/apache/maven/repository/indexing/MetadataRepositoryIndexingTest.java
Modified: maven/repository-manager/trunk/maven-repository-indexer/src/test/java/org/apache/maven/repository/indexing/MetadataRepositoryIndexingTest.java
URL: http://svn.apache.org/viewcvs/maven/repository-manager/trunk/maven-repository-indexer/src/test/java/org/apache/maven/repository/indexing/MetadataRepositoryIndexingTest.java?rev=369655&r1=369654&r2=369655&view=diff
==============================================================================
--- maven/repository-manager/trunk/maven-repository-indexer/src/test/java/org/apache/maven/repository/indexing/MetadataRepositoryIndexingTest.java (original)
+++ maven/repository-manager/trunk/maven-repository-indexer/src/test/java/org/apache/maven/repository/indexing/MetadataRepositoryIndexingTest.java Mon Jan 16 19:24:59 2006
@@ -114,7 +114,7 @@
*
* @throws Exception
*/
- public void testSearchSingle()
+ public void testSearch()
throws Exception
{
createTestIndex();
@@ -180,6 +180,50 @@
indexer.close();
}
+
+ public void testExceptions()
+ throws Exception
+ {
+ //test when the object passed in the index(..) method is not a RepositoryMetadat instance
+ RepositoryIndexingFactory factory = ( RepositoryIndexingFactory ) lookup( RepositoryIndexingFactory.ROLE );
+ indexer = factory.createMetadataRepositoryIndex( indexPath, repository );
+ try
+ {
+ Artifact artifact = getArtifact("org.apache.maven", "maven-artifact", "2.0.1");
+ indexer.index( artifact );
+ fail( "Must throw exception when the passed object is not a RepositoryMetadata object." );
+ }
+ catch( Exception e )
+ {
+ }
+ indexer.optimize();
+ indexer.close();
+
+ //test when the plugin prefix is blank
+ factory = ( RepositoryIndexingFactory ) lookup( RepositoryIndexingFactory.ROLE );
+ indexer = factory.createMetadataRepositoryIndex( indexPath, repository );
+ try
+ {
+ RepositoryMetadata repoMetadata = getMetadata( "test", null, null, "maven-metadata.xml", GROUP_TYPE );
+ indexer.index( repoMetadata );
+ }
+ catch( Exception e )
+ {
+ }
+ indexer.optimize();
+ indexer.close();
+
+ //test when the index is closed
+ try
+ {
+ RepositoryMetadata repoMetadata = getMetadata( "org.apache.maven", null, null, "maven-metadata.xml", GROUP_TYPE );
+ indexer.index( repoMetadata );
+ fail( "Must throw exception when a metadata is added to the index while the indexer is still closed." );
+ }
+ catch( Exception e )
+ {
+ }
+ }
/**
* Create RepositoryMetadata object.
Added: maven/repository-manager/trunk/maven-repository-indexer/src/test/repository/test/maven-metadata.xml
URL: http://svn.apache.org/viewcvs/maven/repository-manager/trunk/maven-repository-indexer/src/test/repository/test/maven-metadata.xml?rev=369655&view=auto
==============================================================================
--- maven/repository-manager/trunk/maven-repository-indexer/src/test/repository/test/maven-metadata.xml (added)
+++ maven/repository-manager/trunk/maven-repository-indexer/src/test/repository/test/maven-metadata.xml Mon Jan 16 19:24:59 2006
@@ -0,0 +1,9 @@
+<metadata>
+<groupId>test</groupId>
+<plugins>
+ <plugin>
+ <prefix></prefix>
+ <artifactId>test-test-plugin</artifactId>
+ </plugin>
+</plugins>
+</metadata>
Re: svn commit: r369655 - in /maven/repository-manager/trunk/maven-repository-indexer/src/test:
java/org/apache/maven/repository/indexing/MetadataRepositoryIndexingTest.java
repository/test/maven-metadata.xml
Posted by Edwin Punzalan <ep...@exist.com>.
Sorry...
I'll get those fixed soon... thanks.
^_^
Brett Porter wrote:
>epunzalan@apache.org wrote:
>
>
>>+ public void testExceptions()
>>+ throws Exception
>>+ {
>>+ //test when the object passed in the index(..) method is not a RepositoryMetadat instance
>>+ RepositoryIndexingFactory factory = ( RepositoryIndexingFactory ) lookup( RepositoryIndexingFactory.ROLE );
>>+ indexer = factory.createMetadataRepositoryIndex( indexPath, repository );
>>+ try
>>+ {
>>+ Artifact artifact = getArtifact("org.apache.maven", "maven-artifact", "2.0.1");
>>+ indexer.index( artifact );
>>+ fail( "Must throw exception when the passed object is not a RepositoryMetadata object." );
>>+ }
>>+ catch( Exception e )
>>+ {
>>+ }
>>
>>
>
>Are you expecting "Exception" or some other type of Exception? You
>should catch the one you actually expect.
>
>I also like this tip from Vincent's Junit book:
>
>catch ( SpecificException expected )
>{
> assertTrue( true );
>}
>
>- Brett
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r369655 - in /maven/repository-manager/trunk/maven-repository-indexer/src/test:
java/org/apache/maven/repository/indexing/MetadataRepositoryIndexingTest.java
repository/test/maven-metadata.xml
Posted by Brett Porter <br...@apache.org>.
epunzalan@apache.org wrote:
> + public void testExceptions()
> + throws Exception
> + {
> + //test when the object passed in the index(..) method is not a RepositoryMetadat instance
> + RepositoryIndexingFactory factory = ( RepositoryIndexingFactory ) lookup( RepositoryIndexingFactory.ROLE );
> + indexer = factory.createMetadataRepositoryIndex( indexPath, repository );
> + try
> + {
> + Artifact artifact = getArtifact("org.apache.maven", "maven-artifact", "2.0.1");
> + indexer.index( artifact );
> + fail( "Must throw exception when the passed object is not a RepositoryMetadata object." );
> + }
> + catch( Exception e )
> + {
> + }
Are you expecting "Exception" or some other type of Exception? You
should catch the one you actually expect.
I also like this tip from Vincent's Junit book:
catch ( SpecificException expected )
{
assertTrue( true );
}
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org