[GitHub] alenl opened a new issue #1127: Deleting an option in Fauxton causes it to be forced to empty instead, overriding local.ini!

[GitBox <gi...@apache.org>]

alenl opened a new issue #1127: Deleting an option in Fauxton causes it to be forced to empty instead, overriding local.ini!
URL: https://github.com/apache/couchdb-fauxton/issues/1127
 
 
   <!--- Provide a general summary of the issue in the Title above -->
   If you click on the trashcan icon by some option, it will not remove that option from local.d/10-admin.ini, but will set the option line to:
   That_Olde_Option = 
   So, if that option has an actual value assigned in local.ini , it will be overwritten with nothing.
   
   ## Expected Behavior
   <!--- If you're describing a bug, tell us what should happen -->
   <!--- If you're suggesting a change/improvement, tell us how it should work -->
   Deleting an option from the Fauxton list would remove the option-value line completely from the admin file, which would make the value from local.ini take over.
   
   ## Current Behavior
   <!--- If describing a bug, tell us what happens instead of the expected behavior -->
   <!--- If suggesting a change/improvement, explain the difference from current behavior -->
   Right now it puts an empty assignment, which is not the same as doing nothing.
   
   ## Possible Solution
   <!--- Not obligatory, but suggest a fix/reason for the bug, -->
   <!--- or ideas how to implement the addition or change -->
   I suggest deleting the line from 10-admin.ini completely. The fact that it is not done that way seems like a small oversight, and simple to fix - but with big and very confusing effects to the admin-user of Fauxton.
   
   ## Steps to Reproduce (for bugs)
   Below, when I say "observe the realm", I mean execute this:
   ```sh
   curl -is https://couch-test-server:6984/ | grep realm
   ```
   (Or whatever protocol/port you use.)
   and check the output.
   
   <!--- Provide a link to a live example, or an unambiguous set of steps to -->
   <!--- reproduce this bug. Include code to reproduce, if relevant -->
   0. Have a test server that uses WWW authentication and requires authorized user .
    (This is the simplest test, because WWW-Authenticate realm is a string that can be set to anything and is easily obtainable from the browser.)
   1. In local.ini, set [httpd] WWW-Authenticate = Basic realm="set_in_local"
   observe the realm is now "set_in_local"
   2. In Fauxton [httpd] WWW-Authenticate = Basic realm="set__in_Fauxton"
   observe the realm is now "set_in_Fauxton"
   3. Click on the trashcan icon for the WWW-Authenticate in Fauxton
   observe the realm is now "server". (This originates from the internal defaults.)
   4. Check contents of etc/local.d/10-admin.ini and notice the line
   ````WWW-Authenticate=````
   
   ## Context
   <!--- How has this issue affected you? What are you trying to accomplish? -->
   <!--- Providing context helps us come up with a solution that is most useful in the real world -->
   When doing any changes, it can be very confusing. If you add a new option in Fauxton, and then remove it, you'd expect that the state of the configuration is as it was before. Alas, it is something completely different! Now that I know about this, I simply will not be using that trashcan icon, because this is definitely no what I wanted to do. But it was super-confusing before I realized what's going on.
   
   ## Your Environment
   <!--- Include as many relevant details about the environment you experienced the bug in -->
   * Version used: 2.2.0 (installed on Ubuntu 16.04)
   * Browser Name and version: Firefox 62.0/x64
   * Operating System and version (desktop or mobile): desktop
   * Link to your project: N/A
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services