You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2014/06/16 20:35:27 UTC
Re: Review Request 21278: OOZIE-1817: Oozie timers are not biased
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21278/#review45783
-----------------------------------------------------------
patch looks good. Please ensure that the cron.start() and cron.stop() are present in all the required commands as I didnt check that myself. After that +1
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/21278/#comment80763>
so no counter for inputcheck command?
- Mona Chitnis
On May 22, 2014, 11:27 p.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21278/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 11:27 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1817
> https://issues.apache.org/jira/browse/OOZIE-1817
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/OOZIE-1817?focusedCommentId=13993838&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13993838
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 97fd465
> core/pom.xml c935dd7
> core/src/main/java/org/apache/oozie/command/Command.java d3f1011
> core/src/main/java/org/apache/oozie/command/XCommand.java b712ce0
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java e8667c1
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 57cbb34
> core/src/main/java/org/apache/oozie/service/InstrumentationService.java 80437b1
> core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java PRE-CREATION
> core/src/main/java/org/apache/oozie/service/Services.java 5feac7b
> core/src/main/java/org/apache/oozie/service/XLogService.java 403a089
> core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 29d7bd6
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 5c05acd
> core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java 97bd81c
> core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java a47f737
> core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java 002a367
> core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java PRE-CREATION
> core/src/main/java/org/apache/oozie/util/XLog.java 21e00c0
> core/src/main/resources/oozie-default.xml 9788daf
> core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java b5206cf
> core/src/test/java/org/apache/oozie/service/TestMetricsInstrumentationService.java PRE-CREATION
> core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 6040b47
> core/src/test/java/org/apache/oozie/util/TestMetricsInstrumentation.java PRE-CREATION
> docs/src/site/twiki/AG_Install.twiki e343d7e
> docs/src/site/twiki/WebServicesAPI.twiki 5769924
> pom.xml b5e0e4e
> webapp/src/main/webapp/index.jsp 3c7ffe5
> webapp/src/main/webapp/oozie-console.js 764d888
>
> Diff: https://reviews.apache.org/r/21278/diff/
>
>
> Testing
> -------
>
> Unit tests, also verified in a cluster
>
>
> Thanks,
>
> Robert Kanter
>
>
Re: Review Request 21278: OOZIE-1817: Oozie timers are not biased
Posted by Robert Kanter <rk...@cloudera.com>.
> On June 16, 2014, 6:35 p.m., Mona Chitnis wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java, line 115
> > <https://reviews.apache.org/r/21278/diff/6/?file=588562#file588562line115>
> >
> > so no counter for inputcheck command?
One of the parent classes, XCommand, already takes care of a few different crons (e.g. ".execute"), so this cron is unnecessary. Plus, it wasn't ever even being reported because instrumentation.addCron(...) was never being called for it anyway.
I'll double-check that crons are being using properly and then upload the latest patch (there were the minor things you pointed out before such as a variable name having a typo, and I got rid of the log4j meters) to JIRA so Jenkins can run it.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21278/#review45783
-----------------------------------------------------------
On May 22, 2014, 11:27 p.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21278/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 11:27 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1817
> https://issues.apache.org/jira/browse/OOZIE-1817
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/OOZIE-1817?focusedCommentId=13993838&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13993838
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 97fd465
> core/pom.xml c935dd7
> core/src/main/java/org/apache/oozie/command/Command.java d3f1011
> core/src/main/java/org/apache/oozie/command/XCommand.java b712ce0
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java e8667c1
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 57cbb34
> core/src/main/java/org/apache/oozie/service/InstrumentationService.java 80437b1
> core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java PRE-CREATION
> core/src/main/java/org/apache/oozie/service/Services.java 5feac7b
> core/src/main/java/org/apache/oozie/service/XLogService.java 403a089
> core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 29d7bd6
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 5c05acd
> core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java 97bd81c
> core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java a47f737
> core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java 002a367
> core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java PRE-CREATION
> core/src/main/java/org/apache/oozie/util/XLog.java 21e00c0
> core/src/main/resources/oozie-default.xml 9788daf
> core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java b5206cf
> core/src/test/java/org/apache/oozie/service/TestMetricsInstrumentationService.java PRE-CREATION
> core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 6040b47
> core/src/test/java/org/apache/oozie/util/TestMetricsInstrumentation.java PRE-CREATION
> docs/src/site/twiki/AG_Install.twiki e343d7e
> docs/src/site/twiki/WebServicesAPI.twiki 5769924
> pom.xml b5e0e4e
> webapp/src/main/webapp/index.jsp 3c7ffe5
> webapp/src/main/webapp/oozie-console.js 764d888
>
> Diff: https://reviews.apache.org/r/21278/diff/
>
>
> Testing
> -------
>
> Unit tests, also verified in a cluster
>
>
> Thanks,
>
> Robert Kanter
>
>