You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by Robert Dale <ro...@gmail.com> on 2018/06/18 21:36:02 UTC
Re: [DISCUSS] Bump to Netty 4.1.x
4.1 will enable us to use compression on WebSocket with
WebSocketServerCompressionHandler
Robert Dale
On Tue, Feb 6, 2018 at 10:42 AM Stephen Mallette <sp...@gmail.com>
wrote:
> We've been on Netty 4.0.x for as long as TinkerPop 3.x has been around.
> That line of code is now EOL and it's recommended that we go to 4.1.x. I
> created this issue:
>
> https://issues.apache.org/jira/browse/TINKERPOP-1884
>
> Perhaps I'll look to do this soon. I guess we should try to do it for 3.2.x
> and 3.3.0 if it can be done without breaking stuff. I guess I'll see what's
> possible. The part I'm not looking forward to is that I think I tried this
> once before and it didn't work - like tests started mysteriously failing :/
>
> Anyway, please let me know if there are any thoughts on this.
>
Re: [DISCUSS] Bump to Netty 4.1.x
Posted by Stephen Mallette <sp...@gmail.com>.
This change is going to require a bump in Spark to 3.2.1:
https://issues.apache.org/jira/browse/TINKERPOP-1993
On Mon, Jun 18, 2018 at 5:41 PM Robert Dale <ro...@gmail.com> wrote:
> Looks like the original issue was re-purposed so I created a new issue.
> https://issues.apache.org/jira/browse/TINKERPOP-1987
>
> Robert Dale
>
>
> On Mon, Jun 18, 2018 at 5:36 PM Robert Dale <ro...@gmail.com> wrote:
>
> > 4.1 will enable us to use compression on WebSocket with
> > WebSocketServerCompressionHandler
> >
> > Robert Dale
> >
> >
> > On Tue, Feb 6, 2018 at 10:42 AM Stephen Mallette <sp...@gmail.com>
> > wrote:
> >
> >> We've been on Netty 4.0.x for as long as TinkerPop 3.x has been around.
> >> That line of code is now EOL and it's recommended that we go to 4.1.x. I
> >> created this issue:
> >>
> >> https://issues.apache.org/jira/browse/TINKERPOP-1884
> >>
> >> Perhaps I'll look to do this soon. I guess we should try to do it for
> >> 3.2.x
> >> and 3.3.0 if it can be done without breaking stuff. I guess I'll see
> >> what's
> >> possible. The part I'm not looking forward to is that I think I tried
> this
> >> once before and it didn't work - like tests started mysteriously failing
> >> :/
> >>
> >> Anyway, please let me know if there are any thoughts on this.
> >>
> >
>
Re: [DISCUSS] Bump to Netty 4.1.x
Posted by Robert Dale <ro...@gmail.com>.
Looks like the original issue was re-purposed so I created a new issue.
https://issues.apache.org/jira/browse/TINKERPOP-1987
Robert Dale
On Mon, Jun 18, 2018 at 5:36 PM Robert Dale <ro...@gmail.com> wrote:
> 4.1 will enable us to use compression on WebSocket with
> WebSocketServerCompressionHandler
>
> Robert Dale
>
>
> On Tue, Feb 6, 2018 at 10:42 AM Stephen Mallette <sp...@gmail.com>
> wrote:
>
>> We've been on Netty 4.0.x for as long as TinkerPop 3.x has been around.
>> That line of code is now EOL and it's recommended that we go to 4.1.x. I
>> created this issue:
>>
>> https://issues.apache.org/jira/browse/TINKERPOP-1884
>>
>> Perhaps I'll look to do this soon. I guess we should try to do it for
>> 3.2.x
>> and 3.3.0 if it can be done without breaking stuff. I guess I'll see
>> what's
>> possible. The part I'm not looking forward to is that I think I tried this
>> once before and it didn't work - like tests started mysteriously failing
>> :/
>>
>> Anyway, please let me know if there are any thoughts on this.
>>
>