You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by cd...@apache.org on 2009/04/16 01:38:14 UTC
svn commit: r765427 - in /hadoop/core/trunk: CHANGES.txt
src/tools/org/apache/hadoop/tools/DistCp.java
Author: cdouglas
Date: Wed Apr 15 23:38:14 2009
New Revision: 765427
URL: http://svn.apache.org/viewvc?rev=765427&view=rev
Log:
HADOOP-5671. Fix FNF exceptions when copying from old versions of
HftpFileSystem. Contributed by Tsz Wo (Nicholas), SZE
Modified:
hadoop/core/trunk/CHANGES.txt
hadoop/core/trunk/src/tools/org/apache/hadoop/tools/DistCp.java
Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=765427&r1=765426&r2=765427&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Wed Apr 15 23:38:14 2009
@@ -394,6 +394,9 @@
HADOOP-5652. Fix a bug where in-memory segments are incorrectly retained in
memory. (cdouglas)
+ HADOOP-5671. Fix FNF exceptions when copying from old versions of
+ HftpFileSystem. (Tsz Wo (Nicholas), SZE via cdouglas)
+
Release 0.20.0 - Unreleased
INCOMPATIBLE CHANGES
Modified: hadoop/core/trunk/src/tools/org/apache/hadoop/tools/DistCp.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/tools/org/apache/hadoop/tools/DistCp.java?rev=765427&r1=765426&r2=765427&view=diff
==============================================================================
--- hadoop/core/trunk/src/tools/org/apache/hadoop/tools/DistCp.java (original)
+++ hadoop/core/trunk/src/tools/org/apache/hadoop/tools/DistCp.java Wed Apr 15 23:38:14 2009
@@ -1171,9 +1171,25 @@
return false;
}
+ //get src checksum
+ final FileChecksum srccs;
+ try {
+ srccs = srcfs.getFileChecksum(srcstatus.getPath());
+ } catch(FileNotFoundException fnfe) {
+ /*
+ * Two possible cases:
+ * (1) src existed once but was deleted between the time period that
+ * srcstatus was obtained and the try block above.
+ * (2) srcfs does not support file checksum and (incorrectly) throws
+ * FNFE, e.g. some previous versions of HftpFileSystem.
+ * For case (1), it is okay to return true since src was already deleted.
+ * For case (2), true should be returned.
+ */
+ return true;
+ }
+
//compare checksums
try {
- final FileChecksum srccs = srcfs.getFileChecksum(srcstatus.getPath());
final FileChecksum dstcs = dstfs.getFileChecksum(dststatus.getPath());
//return true if checksum is not supported
//(i.e. some of the checksums is null)