You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/22 22:53:56 UTC
[GitHub] [tvm] mbs-octoml opened a new pull request #9550: Prepare for switching VM to LowerTEPass.
mbs-octoml opened a new pull request #9550:
URL: https://github.com/apache/tvm/pull/9550
This is a grab bag of fallout changes from switching the VM to use LoweTEPass
which can be ealy split out of the main #9483 PR.
- AnnotateSpans can be used from C++ (though, unfortunately, it didn't help
me with debugging since spans are universally dropped in most passes).
- Can get a human readable dump of the VM's PackedFunc names and indexes for
debugging.
- If TVM_LOG_DEBUG defined then include types and ids of GlobalVars. I had
a lot of difficulty tracking down where duplicate GlobalVars for the same
name_hint were getting created and propagated.
- GetCallLoweredProps follows same API as GetDeviceCopy and GetOnDevice
where will return 'null' properties if call/expr is not of call_lowered
form. Mildly more convenient, though switching all the above to ICHECK
and push 'if (op == the relevant op)' into all use sites would also be just
fine.
- Misc VLOG improvements made while tracking down issues in #9483.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a change in pull request #9550: [Relay] Prepare for switching VM to LowerTEPass.
Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #9550:
URL: https://github.com/apache/tvm/pull/9550#discussion_r756237095
##########
File path: src/relay/op/call/call.cc
##########
@@ -95,20 +96,29 @@ RELAY_REGISTER_OP("call_lowered")
.set_attr<FInferCorrectLayout>("FInferCorrectLayout", ElemwiseArbitraryLayout);
CallLoweredProps GetCallLoweredProps(const CallNode* call_node) {
Review comment:
Given this is such a fundamental function it seems like we should have test cases for all the different cases it throws an exception and what we expect as a return value. Though I equally understand this wasn't authored in this PR.
@mbs-octoml / @electriclilies can you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on a change in pull request #9550: [Relay] Prepare for switching VM to LowerTEPass.
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on a change in pull request #9550:
URL: https://github.com/apache/tvm/pull/9550#discussion_r756165354
##########
File path: include/tvm/runtime/vm/executable.h
##########
@@ -144,6 +144,13 @@ class Executable : public ModuleNode {
*/
std::string GetVirtualDevices() const;
+ /*!
Review comment:
My I please do that in the sequel so we can merge and I take 9483 out of draft? These are just human readable pretty printed descriptions so I can decipher the instructions. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius merged pull request #9550: [Relay] Prepare for switching VM to LowerTEPass.
Posted by GitBox <gi...@apache.org>.
Mousius merged pull request #9550:
URL: https://github.com/apache/tvm/pull/9550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on a change in pull request #9550: [Relay] Prepare for switching VM to LowerTEPass.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #9550:
URL: https://github.com/apache/tvm/pull/9550#discussion_r755601585
##########
File path: include/tvm/runtime/vm/executable.h
##########
@@ -144,6 +144,13 @@ class Executable : public ModuleNode {
*/
std::string GetVirtualDevices() const;
+ /*!
Review comment:
Can you clarify what exactly the return value is here given its just a `std::string`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on a change in pull request #9550: [Relay] Prepare for switching VM to LowerTEPass.
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on a change in pull request #9550:
URL: https://github.com/apache/tvm/pull/9550#discussion_r756290205
##########
File path: src/relay/op/call/call.cc
##########
@@ -95,20 +96,29 @@ RELAY_REGISTER_OP("call_lowered")
.set_attr<FInferCorrectLayout>("FInferCorrectLayout", ElemwiseArbitraryLayout);
CallLoweredProps GetCallLoweredProps(const CallNode* call_node) {
Review comment:
Thanks @Mousius, agree and sorry I missed that in the orig PR. Can you take that @electriclilies ? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] electriclilies commented on a change in pull request #9550: [Relay] Prepare for switching VM to LowerTEPass.
Posted by GitBox <gi...@apache.org>.
electriclilies commented on a change in pull request #9550:
URL: https://github.com/apache/tvm/pull/9550#discussion_r756309064
##########
File path: src/relay/op/call/call.cc
##########
@@ -95,20 +96,29 @@ RELAY_REGISTER_OP("call_lowered")
.set_attr<FInferCorrectLayout>("FInferCorrectLayout", ElemwiseArbitraryLayout);
CallLoweredProps GetCallLoweredProps(const CallNode* call_node) {
Review comment:
Yup!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #9550: [Relay] Prepare for switching VM to LowerTEPass.
Posted by GitBox <gi...@apache.org>.
Mousius commented on pull request #9550:
URL: https://github.com/apache/tvm/pull/9550#issuecomment-978069799
Landing this to move onto #9483, thanks @mbs-octoml !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on a change in pull request #9550: [Relay] Prepare for switching VM to LowerTEPass.
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on a change in pull request #9550:
URL: https://github.com/apache/tvm/pull/9550#discussion_r756165354
##########
File path: include/tvm/runtime/vm/executable.h
##########
@@ -144,6 +144,13 @@ class Executable : public ModuleNode {
*/
std::string GetVirtualDevices() const;
+ /*!
Review comment:
My I please do that in the sequel so we can merge and I take 9483 out of draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org