You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2026/08/14 06:59:59 UTC
[PR] chore: drop Spark 3.4 support [datafusion-comet]
manuzhang opened a new pull request, #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358
## Which issue does this PR close?
Closes #4329.
## Rationale for this change
Spark 3.4 was deprecated in Comet 1.0.0 and is scheduled for removal in 1.1.0. Dropping it reduces the supported build/test matrix and removes compatibility paths that are no longer needed now that Spark 3.5 is the oldest supported release.
## What changes are included in this PR?
- Remove the Spark 3.4 Maven profile, source/test shims, Spark SQL patch, CI jobs, release artifacts, generated compatibility page, and documentation references.
- Simplify shared code and tests to assume Spark 3.5 or newer, including removing the Spark 3.4 AQE dynamic partition-pruning fallback.
- Promote the Spark 3.5 plan-stability overrides into the base golden directories and keep Spark 4.x fallback chains intact.
- Retarget the Iceberg 1.8 compatibility job to Spark 3.5.9 and JDK 17.
## How are these changes tested?
- `make format PROFILES=-Pspark-3.5`
- `./mvnw clean test-compile -DskipTests -Pspark-4.0`
- `./mvnw clean test-compile -DskipTests -Pspark-4.1`
- `./mvnw clean test-compile -DskipTests -Pspark-4.2`
- Focused Spark 3.5 runtime coverage for AQE DPP and hash joins
- `CometTPCDSV1_4_PlanStabilitySuite` on Spark 3.5 (97 tests)
- `CometTPCDSV2_7_PlanStabilitySuite` on Spark 3.5 (32 tests)
- YAML, shell syntax, Python bytecode, active-reference, and `git diff --check` validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on code in PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#discussion_r3909734625
##########
spark/src/main/spark-3.x/org/apache/comet/shims/CometCollectShim.scala:
##########
@@ -22,7 +22,7 @@ package org.apache.comet.shims
import org.apache.spark.sql.catalyst.expressions.aggregate.{CollectList, CollectSet}
/**
- * Shim for the `ignoreNulls` flag on `CollectList` / `CollectSet`. Spark 3.4 through 4.1 have no
+ * Shim for the `ignoreNulls` flag on `CollectList` / `CollectSet`. Spark 3.5 through 4.1 have no
Review Comment:
I would say this is a great opportunity to clean up majorVerSrc in pom, not only moving files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5350425974
> This doesn't make sense on the main branch since codes committed will never be shipped.
Thanks @manuzhang It's more than that, we focusing on stopping Spark 3.4 support soon, however grace period may take some time. Comet evolving fast and there are still bunch of scenarios still using 3.4. I'm afraid back porting major features to 3.4 would take much more efforts than just supporting it for now.
Do you see any risks in having 3.4 during following weeks?
We can keep this PR opened and get back to it as soon as we can, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5339850433
@comphead It's already announced in [1.0.0 release blog](https://datafusion.apache.org/blog/output/2026/08/07/datafusion-comet-1.0.0/).
> Apache Spark 3.4 is deprecated and scheduled for removal in Comet 1.1.0.
Where else do we need to add a warn message and update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5345742782
> @comphead It's already announced in [1.0.0 release blog](https://datafusion.apache.org/blog/output/2026/08/07/datafusion-comet-1.0.0/).
>
> > Apache Spark 3.4 is deprecated and scheduled for removal in Comet 1.1.0.
>
> Where else do we need to add a warn message and update?
I was thinking to add a warn runtime message that Spark 3.4 support is sunsetting. Not sure if it makes sense though.
But still I would propose doing a soft drop:
- disable CI first to save resources
Keep the code for couple of more weeks and drop it closer to the dedicated release date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#discussion_r3836408357
##########
spark/src/main/spark-3.x/org/apache/comet/shims/CometCollectShim.scala:
##########
@@ -22,7 +22,7 @@ package org.apache.comet.shims
import org.apache.spark.sql.catalyst.expressions.aggregate.{CollectList, CollectSet}
/**
- * Shim for the `ignoreNulls` flag on `CollectList` / `CollectSet`. Spark 3.4 through 4.1 have no
+ * Shim for the `ignoreNulls` flag on `CollectList` / `CollectSet`. Spark 3.5 through 4.1 have no
Review Comment:
I don't think it's necessary. Just moving files around doesn't add much value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5350246079
3.4 is still on [branch-1.0](https://github.com/apache/datafusion-comet/tree/branch-1.0) and bug fixes can be released on 1.0.x.
> Keep the code for couple of more weeks and drop it closer to the dedicated release date
This doesn't make sense on the main branch since codes committed will never be shipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#discussion_r3788057038
##########
.github/workflows/pr_build_linux.yml:
##########
@@ -336,7 +329,7 @@ jobs:
- name: "exec"
value: |
org.apache.comet.exec.CometAggregateSuite
- org.apache.comet.exec.CometExec3_4PlusSuite
+ org.apache.comet.exec.CometExecCompatibilitySuite
Review Comment:
Yes, `CometExecCompatibilitySuite` is renamed from `CometExec3_4PlusSuite` and used by all supported Spark versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5350459236
@comphead
> I'm afraid back porting major features to 3.4 would take much more efforts than just supporting it for now.
Which major features do we need to land on 3.4? Any open issues and pull requests?
> We can keep this PR opened and get back to it as soon as we can, WDYT?
No problem, but if we decide to add more features to 3.4, then we shouldn't drop the support now (for 1.1.0). We can't have both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5603429099
@andygrove I don't think we can drop Spark 3.4 support now, since those efforts will be otherwise wasted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5323765663
@andygrove @coderfender @comphead I'd appreciate your review here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "andygrove (via GitHub) via github" <gi...@datafusion.apache.org>.
andygrove commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-6665238059
Thanks for working on this @manuzhang. I think we should do this in smaller steps rather than one large PR.
I took the liberty of creating PR for step 1 - removing the Maven profile and stop running the 3.4 tests in CI. It does not delete any of the code.
https://github.com/apache/datafusion-comet/pull/7521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on code in PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#discussion_r3787249484
##########
.github/workflows/pr_build_linux.yml:
##########
@@ -336,7 +329,7 @@ jobs:
- name: "exec"
value: |
org.apache.comet.exec.CometAggregateSuite
- org.apache.comet.exec.CometExec3_4PlusSuite
+ org.apache.comet.exec.CometExecCompatibilitySuite
Review Comment:
Is this used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5346403911
What does the community think about retaining the code for 3.4 (but maybe relaxed ci and backporting of fixes)? We have a ton of users (and even more production jobs) still on 3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "hsiang-c (via GitHub)" <gi...@apache.org>.
hsiang-c commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5349477111
I'd like to have extended Spark 3.4 support for 2 quarters b/c lots of users are still with Spark 3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "coderfender (via GitHub)" <gi...@apache.org>.
coderfender commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5323771588
Sure! Thank you for the pr @manuzhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on code in PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#discussion_r3816651171
##########
spark/src/main/spark-3.x/org/apache/comet/shims/CometCollectShim.scala:
##########
@@ -22,7 +22,7 @@ package org.apache.comet.shims
import org.apache.spark.sql.catalyst.expressions.aggregate.{CollectList, CollectSet}
/**
- * Shim for the `ignoreNulls` flag on `CollectList` / `CollectSet`. Spark 3.4 through 4.1 have no
+ * Shim for the `ignoreNulls` flag on `CollectList` / `CollectSet`. Spark 3.5 through 4.1 have no
Review Comment:
Does it make sense to move `spark-3.x` to `spark-3.5`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5608501348
Thanks for the rebase; the branch is on current `main` now and merges cleanly. But your own reply is the thing to settle before any of the mechanical review matters.
> I don't think we can drop Spark 3.4 support now, since those efforts will be otherwise wasted.
If that is where you have landed, I would rather this sat as a draft, or closed with an issue tracking the removal, than stayed open as a rebase-and-conflict treadmill. It touches the Maven profiles, the shim directories, `dev/diffs/3.4.3.diff`, three CI matrices and `compute-changes.py`, so it will conflict with almost anything that lands, and someone will keep having to rebase it for a decision that has not been made. Which would you prefer? If the answer is "hold", I am happy to convert it to a draft myself.
On the substance, since it is worth recording either way: the mechanical work is sound. I went through it in detail and found nothing removed that 3.5, 4.0, 4.1 or 4.2 still needs. `isSpark35Plus` is deleted rather than left as an always-true guard, `CometSpark34AqeDppFallbackRule` is gone with all its call sites and tag fields, the unreachable `classOf[Base64] -> CometBase64` mapping is cleaned up, and only `3.4.3.diff` was touched under `dev/diffs/` with no hand-editing of the surviving diffs. If the project decides to drop 3.4 later, this is the change to pick up rather than redo.
The three items @comphead cited as reasons to hold are all resolved now (#4837 closed, #4547 closed, #5314 merged), and their `CHANGES_REQUESTED` from 19 August is still the blocking review. @comphead, whichever way the timing question goes, could you clear or restate that? At the moment the PR is blocked on a review whose stated reasons no longer apply, which makes it hard to tell whether the remaining objection is those specific items or the broader "not yet".
My own view on the timing, for the record: I do not think the argument that in-flight 3.4 work would be wasted is a reason to keep 3.4 indefinitely, but it is a reason not to drop it in the middle of that work. So a tracked deferral with a target version seems right, rather than either merging now or closing without a plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5847307912
@andygrove @sunchao Can we stop automatic reviews like the above? They are creating more noises and wasting tokens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5847614506
OK let me do that. I thought it should already ignoring draft PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5604648042
> @andygrove I don't think we can drop Spark 3.4 support now, since those efforts will be otherwise wasted.
Sorry, that was an autoamted review. I agree that we can't drop the support yet. We should update the docs to remove the claim that support will be dropped in 1.1.0 and instead say that it will be dropped in a future release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: drop Spark 3.4 support [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#issuecomment-5350493131
I would expect to see #4837 #4547 #5314 and some other things currently in progress like shuffle writes are slow for nested schemas, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org