You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/03/25 12:57:39 UTC
[GitHub] [hive] pvary commented on a change in pull request #3139: HIVE-26069: Remove unnecessary items from the .gitignore
pvary commented on a change in pull request #3139:
URL: https://github.com/apache/hive/pull/3139#discussion_r835245082
##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Derby.java
##########
@@ -88,7 +88,7 @@ public String getInitialJdbcUrl(String hostAddress) {
}
public String getDb() {
- return MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
+ return "${test.tmp.dir}/" + MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
Review comment:
We already use the prefix for the in memory datastore in multiple places:
https://github.com/apache/hive/blob/2524c2137bc2e70bd32e43a49a15fbfc0fa93159/standalone-metastore/metastore-server/pom.xml#L395
https://github.com/apache/hive/blob/2524c2137bc2e70bd32e43a49a15fbfc0fa93159/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactoryForTests.java#L90-L92
https://github.com/apache/hive/blob/2524c2137bc2e70bd32e43a49a15fbfc0fa93159/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java#L841-L842
I am not saying that this is good, I just state that we already use this several times already 😄.
Had to remove this change anyway, since the test failures for `TestMiniLlapLocalCliDriver`, `TestCliDriver`, ... are caused by this and the fix is not straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org