You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hvanhovell <gi...@git.apache.org> on 2016/01/26 00:34:59 UTC
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/10905
[SPARK-12865][SPARK-12866][SQL] Migrate SparkSQLParser/ExtendedHiveQlParser commands to new Parser [WIP]
This PR moves all the functionality provided by the SparkSQLParser/ExtendedHiveQlParser to the new Parser hierarchy (SparkQl/HiveQl). This also improves the current SET command parsing: the current implementation swallows ```set role ...``` and ```set autocommit ...``` commands, this PR respects these commands (and passes them on to Hive).
This PR and https://github.com/apache/spark/pull/10723 end the use of Parser-Combinator parsers for SQL parsing. As a result we can also remove the ```AbstractSQLParser``` in Catalyst.
The PR is marked WIP as long as it doesn't pass all tests.
cc @rxin @viirya @winningsix (this touched https://github.com/apache/spark/pull/10144)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hvanhovell/spark SPARK-12866
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10905.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10905
----
commit eaee5c1708899d8fbe5764559de5da0be8a755bb
Author: Herman van Hovell <hv...@questtec.nl>
Date: 2016-01-17T20:00:29Z
Add ExtendedHiveQlParser and SparkSQLParser grammar to parser.
commit ff50b5266f4992a8503d069249f76d8447872ab7
Author: Herman van Hovell <hv...@questtec.nl>
Date: 2016-01-18T00:24:07Z
Move SparkSQLParser functionality into the new parser.
commit 85eb26dbb3b3c61c8d5ae4872bc8b316af213c54
Author: Herman van Hovell <hv...@questtec.nl>
Date: 2016-01-18T20:12:29Z
Move SparkSQLParser functionality into the new parser.
commit 7a21ea10c27b95b8d1e6a631a7c6c522941a070f
Author: Herman van Hovell <hv...@questtec.nl>
Date: 2016-01-20T21:46:03Z
Add set/dfs/add partial commands
commit 3a3f32c090b7f680b147b6fdc51c8955c3a0f5dd
Author: Herman van Hovell <hv...@questtec.nl>
Date: 2016-01-20T21:49:19Z
Merge remote-tracking branch 'spark/master' into SPARK-12866
# Conflicts:
# sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSQLParser.scala
commit 259027dda0de5abaa858306225b9eae7274b891c
Author: Herman van Hovell <hv...@questtec.nl>
Date: 2016-01-25T23:22:21Z
Add proper 'set' command parsing.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10905#discussion_r51015733
--- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/ExpressionParser.g ---
@@ -167,8 +167,8 @@ intervalLiteral
((intervalConstant KW_HOUR)=> hour=intervalConstant KW_HOUR)?
((intervalConstant KW_MINUTE)=> minute=intervalConstant KW_MINUTE)?
((intervalConstant KW_SECOND)=> second=intervalConstant KW_SECOND)?
- (millisecond=intervalConstant KW_MILLISECOND)?
- (microsecond=intervalConstant KW_MICROSECOND)?
+ ((intervalConstant KW_MILLISECOND)=> millisecond=intervalConstant KW_MILLISECOND)?
--- End diff --
This is a leftover chore from a previous PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-175797160
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50194/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-174736998
**[Test build #50039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50039/consoleFull)** for PR 10905 at commit [`45d537c`](https://github.com/apache/spark/commit/45d537c10d341ff2352db6aab4a94cc62a59f5e2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10905#discussion_r51015316
--- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlParser.g ---
@@ -687,8 +699,12 @@ catch (RecognitionException e) {
// starting rule
statement
- : explainStatement EOF
- | execStatement EOF
+ : explainStatement EOF
+ | execStatement EOF
+ | KW_ADD KW_JAR -> ^(TOK_ADDJAR)
--- End diff --
These match rules do not match until EOF. We will use the raw input after we encouter such a token.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-174748123
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50043/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-174749036
**[Test build #50039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50039/consoleFull)** for PR 10905 at commit [`45d537c`](https://github.com/apache/spark/commit/45d537c10d341ff2352db6aab4a94cc62a59f5e2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-175754138
**[Test build #50194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50194/consoleFull)** for PR 10905 at commit [`5177926`](https://github.com/apache/spark/commit/51779262153a985b472ef4e1f52b9cf2f7a6827f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10905
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10905#discussion_r51015082
--- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlParser.g ---
@@ -2438,12 +2455,11 @@ BEGIN user defined transaction boundaries; follows SQL 2003 standard exactly exc
sqlTransactionStatement
@init { pushMsg("transaction statement", state); }
@after { popMsg(state); }
- :
- startTransactionStatement
- | commitStatement
- | rollbackStatement
- | setAutoCommitStatement
- ;
--- End diff --
Removed TAB's...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-174748121
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10905#discussion_r51052354
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ASTNode.scala ---
@@ -55,10 +55,16 @@ case class ASTNode(
}
/** Origin of the ASTNode. */
- override val origin = Origin(Some(line), Some(positionInLine))
+ override val origin: Origin = Origin(Some(line), Some(positionInLine))
/** Source text. */
- lazy val source = stream.toString(startIndex, stopIndex)
+ lazy val source: String = stream.toString(startIndex, stopIndex)
+
+ /** Get the source text that remains after this token. */
--- End diff --
would be great to briefly mention what this is used for (set?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-174734859
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10905#discussion_r51015437
--- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/ExpressionParser.g ---
@@ -553,6 +551,8 @@ nonReserved
| KW_SNAPSHOT
| KW_AUTOCOMMIT
| KW_ANTI
+ | KW_WEEK | KW_MILLISECOND | KW_MICROSECOND
--- End diff --
This is a leftover chore from a previous PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-175796017
**[Test build #50194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50194/consoleFull)** for PR 10905 at commit [`5177926`](https://github.com/apache/spark/commit/51779262153a985b472ef4e1f52b9cf2f7a6827f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-174737287
"The PR is marked WIP as long as it doesn't pass all tests."
This is obvious so if you are only looking to run through the tests, we can just remove the WIP now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-175797154
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-174749144
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50039/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10905#discussion_r51052460
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ASTNode.scala ---
@@ -55,10 +55,16 @@ case class ASTNode(
}
/** Origin of the ASTNode. */
- override val origin = Origin(Some(line), Some(positionInLine))
+ override val origin: Origin = Origin(Some(line), Some(positionInLine))
/** Source text. */
--- End diff --
this comment isn't super useful - can you explain a bit more what "source text" is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-174734862
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50036/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10905#discussion_r50800538
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ASTNode.scala ---
@@ -60,6 +60,12 @@ case class ASTNode(
/** Source text. */
lazy val source = stream.toString(startIndex, stopIndex)
+ /** Get the source text that remains after this token. */
+ lazy val remainder = {
--- End diff --
if you are updating the pr, can you add explicit types for all the public vals?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-174749137
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12865][SPARK-12866][SQL] Migrate SparkS...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10905#issuecomment-175871375
I'm going to merge this. Please address the minor feedback in a follow-up pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org