[GitHub] [rocketmq] mxsm commented on a diff in pull request #5515: InterruptedException should not be ignored

[GitBox <gi...@apache.org>]

mxsm commented on code in PR #5515:
URL: https://github.com/apache/rocketmq/pull/5515#discussion_r1022355802


##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -1423,6 +1423,8 @@ protected void shutdownScheduledExecutorService(ScheduledExecutorService schedul
         try {
             scheduledExecutorService.awaitTermination(5000, TimeUnit.MILLISECONDS);
         } catch (InterruptedException ignore) {
+            BrokerController.LOG.warn("shutdown ScheduledExecutorService was Interrupted!  ", ignore);
+        	Thread.currentThread().interrupt();

Review Comment:
   https://github.com/apache/rocketmq/actions/runs/3449152754/jobs/5767526841
   Error:  /home/runner/work/rocketmq/rocketmq/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:1427:9: File contains tab characters (this is the first instance). [FileTabCharacter]
   Error:  /home/runner/work/rocketmq/rocketmq/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:1427:17: 'catch' child has incorrect indentation level 16, expected level should be 12. [Indentation]
   
   Here has some problems need to fix in CI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org