[jira] [Comment Edited] (MESOS-9305) Create cgoup recursively when calling prepare on containers

["Jie Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644455#comment-16644455 ] 

Jie Yu edited comment on MESOS-9305 at 10/10/18 4:54 AM:
---------------------------------------------------------

[~carlone] yeah, I think that sounds good to me. I don't have better alternatives. Can you send a PR? I am happy to shepherd it.


was (Author: jieyu):
[~carlone] yeah, I think that sounds good to me. I don't have better alternatives. Can you send a PR?

> Create cgoup recursively when calling prepare on containers
> -----------------------------------------------------------
>
>                 Key: MESOS-9305
>                 URL: https://issues.apache.org/jira/browse/MESOS-9305
>             Project: Mesos
>          Issue Type: Improvement
>    Affects Versions: 1.5.1, 1.6.1, 1.7.0
>            Reporter: longfei
>            Assignee: longfei
>            Priority: Critical
>
> This is my case:
> My cgroups_root of mesos-slave is some_user/mesos under /sys/fs/cgroup。
> It happens that this some_user dir may be gone for some unknown reason, in which case I can no longer create any cgroup and any task will fail.
> So I would like to change 
>  
> {code:java}
> Try<Nothing> create = cgroups::create(
> hierarchy,
> infos[containerId]->cgroup);
> {code}
> to
> {code:java}
> Try<Nothing> create = cgroups::create(
> hierarchy,
> infos[containerId]->cgroup,
> true);
> {code}
> in CgroupsIsolatorProcess::prepare in src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp.
> However, I'm not sure if there's any potential problem doing so. Any advice?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)