You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ja...@apache.org on 2015/07/16 01:39:55 UTC

svn commit: r1691294 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/RadialShadingContext.java

Author: jahewson
Date: Wed Jul 15 23:39:55 2015
New Revision: 1691294

URL: http://svn.apache.org/r1691294
Log:
PDFBOX-2881: Simplistic computation of radial shading bounds

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/RadialShadingContext.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/RadialShadingContext.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/RadialShadingContext.java?rev=1691294&r1=1691293&r2=1691294&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/RadialShadingContext.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/RadialShadingContext.java Wed Jul 15 23:39:55 2015
@@ -20,7 +20,6 @@ import java.awt.PaintContext;
 import java.awt.Rectangle;
 import java.awt.geom.AffineTransform;
 import java.awt.geom.NoninvertibleTransformException;
-import java.awt.geom.Point2D;
 import java.awt.image.ColorModel;
 import java.awt.image.Raster;
 import java.awt.image.WritableRaster;
@@ -126,14 +125,10 @@ public class RadialShadingContext extend
         AffineTransform shadingToDevice = (AffineTransform)xform.clone();
         shadingToDevice.concatenate(matrix.createAffineTransform());
 
-        // convert connects two circles' centers coordinates to device space
-        Point2D p0 = new Point2D.Double(coords[0], coords[1]);
-        Point2D p1 = new Point2D.Double(coords[3], coords[4]);
-        shadingToDevice.transform(p0, p0);
-        shadingToDevice.transform(p1, p1);
-
-        // the distance between them is number of steps
-        factor = (int)Math.round(p0.distance(p1));
+        // worst case for the number of steps is opposite diagonal corners, so use that
+        double dist = Math.sqrt(Math.pow(deviceBounds.getMaxX() - deviceBounds.getMinX(), 2) +
+                                Math.pow(deviceBounds.getMaxY() - deviceBounds.getMinX(), 2));
+        factor = (int) Math.ceil(dist);
 
         // build the color table for the given number of steps
         colorTable = calcColorTable();