You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/11/15 08:30:02 UTC
[GitHub] zeppelin pull request #1634: [MINOR] Add markdown escaping to find missing p...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1634
[MINOR] Add markdown escaping to find missing parts
### What is this PR for?
Currently `{{note.id}}>{{noteName(note)}}` is not shown in `notebookashomepage.md`. So I added markdown escaping for this.
### What type of PR is it?
Documentation
### What is the Jira issue?
no Jira issue for this
### How should this be tested?
Please see the below screenshot imgs :)
### Screenshots (if appropriate)
- Before
<img width="797" alt="screen shot 2016-11-15 at 9 22 15 am" src="https://cloud.githubusercontent.com/assets/10060731/20298331/9b2e8828-ab15-11e6-9010-50df6100a961.png">
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin add-markdown-escaping
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1634.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1634
----
commit 34a4bc7f66540802ebea2b4f990d426734d2e726
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-11-15T08:20:53Z
Add markdown escaping to find some missing parts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1634: [MINOR] Add markdown escaping to find missing parts
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1634
@tae-jun Thanks!
Merge if there are no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1634: [MINOR] Add markdown escaping to find missing parts
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1634
LGTM! \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1634: [MINOR] Add markdown escaping to find missing p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1634
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---