You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/24 09:55:37 UTC
[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #258:
feat(producer): add regionId support in the send result
ShannonDing opened a new pull request #258: feat(producer): add regionId support in the send result
URL: https://github.com/apache/rocketmq-client-cpp/pull/258
## What is the purpose of the change
feat(producer): add regionId support in the send result
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #258:
feat(producer): add regionId support in the send result
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #258: feat(producer): add regionId support in the send result
URL: https://github.com/apache/rocketmq-client-cpp/pull/258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #258:
feat(producer): add regionId support in the send result
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #258: feat(producer): add regionId support in the send result
URL: https://github.com/apache/rocketmq-client-cpp/pull/258#issuecomment-590258603
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258?src=pr&el=h1) Report
> Merging [#258](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/41d7c35edc88691ed4a52afff1847211454797f8?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `93.54%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 57.69% 57.86% +0.16%
==========================================
Files 182 182
Lines 11652 11680 +28
==========================================
+ Hits 6723 6759 +36
+ Misses 4929 4921 -8
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/SendResult.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258/diff?src=pr&el=tree#diff-aW5jbHVkZS9TZW5kUmVzdWx0Lmg=) | `0% <ø> (ø)` | :arrow_up: |
| [src/MQClientAPIImpl.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50QVBJSW1wbC5jcHA=) | `24.48% <100%> (ø)` | :arrow_up: |
| [src/protocol/CommandHeader.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuY3Bw) | `85.71% <100%> (+0.27%)` | :arrow_up: |
| [test/src/protocol/CommandHeaderTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29tbWFuZEhlYWRlclRlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [test/src/producer/DefaultMQProducerImplTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvZHVjZXIvRGVmYXVsdE1RUHJvZHVjZXJJbXBsVGVzdC5jcHA=) | `98.26% <100%> (+0.03%)` | :arrow_up: |
| [src/protocol/CommandHeader.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuaA==) | `79.76% <100%> (+0.49%)` | :arrow_up: |
| [src/producer/SendResult.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258/diff?src=pr&el=tree#diff-c3JjL3Byb2R1Y2VyL1NlbmRSZXN1bHQuY3Bw) | `95.65% <75%> (+21.96%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258?src=pr&el=footer). Last update [41d7c35...b7cd030](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services