[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #20694: [enhancement](insert-stmt) Make `insert into tbl values();` compatible with mysql

["TangSiyang2001 (via GitHub)" <gi...@apache.org>]

TangSiyang2001 commented on code in PR #20694:
URL: https://github.com/apache/doris/pull/20694#discussion_r1227710159


##########
regression-test/suites/load_p0/insert/test_insert.groovy:
##########
@@ -48,4 +48,24 @@ suite("test_insert") {
     """
 
     qt_sql1 "select * from ${insert_tbl} order by 1, 2, 3, 4"
+
+    def insert_tbl_dft = "test_insert_dft_tbl"
+    sql """ DROP TABLE IF EXISTS ${insert_tbl_dft}"""
+    sql """
+        CREATE TABLE ${insert_tbl_dft} (
+            `k1` char(8) DEFAULT "hello",
+            `k2` char(8) DEFAULT "world",
+            `k3` int(10) DEFAULT "0"

Review Comment:
   @yiguolei If we use `current_timestamp` as default value in regression-test, will the result become unstable because the `current_timestamp` is changing all the time? Maybe we can use expr like `to_date` to produce a stable result.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org