[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…

["reschke (via GitHub)" <gi...@apache.org>]

reschke commented on code in PR #96:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185786325


##########
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##########
@@ -397,8 +397,8 @@ public void mapResourceWithVanityPathsURLTargetNoPath() {
         ExpectedMappings.existingResource("/vain-url-nopath")
             .singleMapping("/vain-url-nopath")
             .singleMappingWithRequest("/app/vain-url-nopath")
-            .allMappings("/vain-url-nopath", "")
-            .allMappingsWithRequest("/app/vain-url-nopath", "")

Review Comment:
   This changes existing behavior. I believe this is very risky.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org