You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/20 22:09:05 UTC
[GitHub] [incubator-mxnet] barry-jin opened a new pull request #20546: [API] Add new dlpack API
barry-jin opened a new pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546
## Description ##
Add new dlpack API specified in Array API standardizaiton #20501
References:
1. Discussion on synchronization dmlc/dlpack#57
2. New dlpack API in TVM apache/tvm#7993
3. New dlpack API in pytorch pytorch/pytorch#57110
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [x] `__dlpack__(self, stream=None)` and `__dlpack_device__(self)`
- [x] Add synchronization between consumer and producer
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-970555465
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-969154795
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [WIP][API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-957048182
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-965943823
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-966038220
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-965971832
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-969154739
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-970507359
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-970507410
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-970721949
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-967702752
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964858275
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964373908
@mxnet-bot run ci [centos-cpu, centos-gpu, unix-cpu, unix-gpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-968434655
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-967289907
Jenkins CI successfully triggered : [unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [WIP][API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-957048129
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [WIP][API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-957048182
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [WIP][API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-957048129
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-902982517
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, website, clang, unix-cpu, unix-gpu, sanity, centos-gpu, windows-cpu, centos-cpu, miscellaneous, windows-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-966850873
Jenkins CI successfully triggered : [unix-gpu, unix-cpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-969451223
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-967702714
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-968105475
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#discussion_r747559406
##########
File path: tests/python/array-api/test_data_interchange.py
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import mxnet as mx
+from mxnet import np
+import torch
+
+
+def test_dlpack_torch_mxnet_torch():
+ stream = torch.cuda.Stream()
+ with torch.cuda.stream(stream):
+ x = torch.tensor((5,), device='cuda:0', dtype=torch.float64) + 1
+ mx = np.from_dlpack(x)
+ stream = torch.cuda.Stream()
+ with torch.cuda.stream(stream):
+ z = torch.from_dlpack(mx)
+ stream.synchronize()
+ z += 1
+ assert z == x
+
+def test_dlpack_mxnet_torch_mxnet():
Review comment:
Can you also add tests for the expected errors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [WIP][API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-962661374
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964858319
Jenkins CI successfully triggered : [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-965841928
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-965841964
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [WIP][API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-957048182
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-966850810
@mxnet-bot run ci [unix-cpu, unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964650974
Jenkins CI successfully triggered : [unix-cpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964373989
Jenkins CI successfully triggered : [windows-gpu, centos-gpu, centos-cpu, unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964490597
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-969451320
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-968434631
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-966600088
Jenkins CI successfully triggered : [unix-gpu, website, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-966600026
@mxnet-bot run ci [unix-cpu, unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-965636537
Jenkins CI successfully triggered : [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-965636475
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-965943853
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-965971795
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#discussion_r747559005
##########
File path: src/c_api/c_api.cc
##########
@@ -3947,7 +3947,25 @@ int MXShallowCopyNDArray(NDArrayHandle src_handle, NDArrayHandle* out) {
API_END_HANDLE_ERROR(delete ret);
}
-int MXNVTXRangePush(const char * name, mx_uint color) {
+int MXPushStreamDep(NDArrayHandle handle, int stream) {
+ API_BEGIN();
+ static_cast<NDArray*>(handle)->StreamSync(stream);
+ API_END();
+}
+
+int MXGetCurrentStream(int device_id, int* stream) {
+ API_BEGIN();
+#if MXNET_USE_CUDA
+ RunContext rctx{Context::GPU(device_id), nullptr, nullptr};
+ mshadow::Stream<gpu>* cur_stream = rctx.get_stream<gpu>();
+ *stream = reinterpret_cast<int64_t>(mshadow::Stream<gpu>::GetStream(cur_stream));
+#else
+ LOG(FATAL) << "Compile with USE_CUDA=1 to have CUDA runtime compilation.";
Review comment:
I'm guessing you meant to report some other error here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964650921
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-970555404
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [WIP][API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-962661364
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964490635
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964678308
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-966038255
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-967289827
@mxnet-bot run ci [unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-967526978
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-976150610
@barry-jin the PR looks OK. Could you resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-977234688
Jenkins CI successfully triggered : [miscellaneous]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-977234641
@mxnet-bot run ci [miscellaneous]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [WIP][API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-957048129
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-964678340
Jenkins CI successfully triggered : [unix-cpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-967526872
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-968105468
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-970721977
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-966734855
Jenkins CI successfully triggered : [unix-cpu, windows-gpu, unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20546: [API] Add new dlpack API
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20546:
URL: https://github.com/apache/incubator-mxnet/pull/20546#issuecomment-966734806
@mxnet-bot run ci [unix-cpu, unix-gpu, website, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org