You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org> on 2010/06/27 15:17:49 UTC

[jira] Created: (PIG-1469) DefaultDataBag assumes ArrayList as default List type

DefaultDataBag assumes ArrayList as default List type
-----------------------------------------------------

                 Key: PIG-1469
                 URL: https://issues.apache.org/jira/browse/PIG-1469
             Project: Pig
          Issue Type: Bug
          Components: data
    Affects Versions: 0.8.0
            Reporter: Gianmarco De Francisci Morales
             Fix For: 0.8.0


In org.apache.pig.data.DefaultDataBag, the field mContents is assumed to be of type ArrayList but the user can actually pass a different List to the constructor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1469) DefaultDataBag assumes ArrayList as default List type

Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883002#action_12883002 ] 

Gianmarco De Francisci Morales commented on PIG-1469:
-----------------------------------------------------

The failures seem related to hudson.
There is no unit test because it is a trivial change.
If needed, I can provide some simple test case.

> DefaultDataBag assumes ArrayList as default List type
> -----------------------------------------------------
>
>                 Key: PIG-1469
>                 URL: https://issues.apache.org/jira/browse/PIG-1469
>             Project: Pig
>          Issue Type: Bug
>          Components: data
>    Affects Versions: 0.8.0
>            Reporter: Gianmarco De Francisci Morales
>            Assignee: Gianmarco De Francisci Morales
>             Fix For: 0.8.0
>
>         Attachments: PIG-1469.patch
>
>
> In org.apache.pig.data.DefaultDataBag, the field mContents is assumed to be of type ArrayList but the user can actually pass a different List to the constructor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1469) DefaultDataBag assumes ArrayList as default List type

Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gianmarco De Francisci Morales updated PIG-1469:
------------------------------------------------

    Attachment: PIG-1469.patch

> DefaultDataBag assumes ArrayList as default List type
> -----------------------------------------------------
>
>                 Key: PIG-1469
>                 URL: https://issues.apache.org/jira/browse/PIG-1469
>             Project: Pig
>          Issue Type: Bug
>          Components: data
>    Affects Versions: 0.8.0
>            Reporter: Gianmarco De Francisci Morales
>             Fix For: 0.8.0
>
>         Attachments: PIG-1469.patch
>
>
> In org.apache.pig.data.DefaultDataBag, the field mContents is assumed to be of type ArrayList but the user can actually pass a different List to the constructor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1469) DefaultDataBag assumes ArrayList as default List type

Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gianmarco De Francisci Morales updated PIG-1469:
------------------------------------------------

      Status: Patch Available  (was: Open)
    Assignee: Gianmarco De Francisci Morales

> DefaultDataBag assumes ArrayList as default List type
> -----------------------------------------------------
>
>                 Key: PIG-1469
>                 URL: https://issues.apache.org/jira/browse/PIG-1469
>             Project: Pig
>          Issue Type: Bug
>          Components: data
>    Affects Versions: 0.8.0
>            Reporter: Gianmarco De Francisci Morales
>            Assignee: Gianmarco De Francisci Morales
>             Fix For: 0.8.0
>
>         Attachments: PIG-1469.patch
>
>
> In org.apache.pig.data.DefaultDataBag, the field mContents is assumed to be of type ArrayList but the user can actually pass a different List to the constructor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1469) DefaultDataBag assumes ArrayList as default List type

Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy updated PIG-1469:
-----------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

I committed this.

> DefaultDataBag assumes ArrayList as default List type
> -----------------------------------------------------
>
>                 Key: PIG-1469
>                 URL: https://issues.apache.org/jira/browse/PIG-1469
>             Project: Pig
>          Issue Type: Bug
>          Components: data
>    Affects Versions: 0.8.0
>            Reporter: Gianmarco De Francisci Morales
>            Assignee: Gianmarco De Francisci Morales
>             Fix For: 0.8.0
>
>         Attachments: PIG-1469.patch
>
>
> In org.apache.pig.data.DefaultDataBag, the field mContents is assumed to be of type ArrayList but the user can actually pass a different List to the constructor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (PIG-1469) DefaultDataBag assumes ArrayList as default List type

Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy closed PIG-1469.
----------------------------------


> DefaultDataBag assumes ArrayList as default List type
> -----------------------------------------------------
>
>                 Key: PIG-1469
>                 URL: https://issues.apache.org/jira/browse/PIG-1469
>             Project: Pig
>          Issue Type: Bug
>          Components: data
>    Affects Versions: 0.8.0
>            Reporter: Gianmarco De Francisci Morales
>            Assignee: Gianmarco De Francisci Morales
>             Fix For: 0.8.0
>
>         Attachments: PIG-1469.patch
>
>
> In org.apache.pig.data.DefaultDataBag, the field mContents is assumed to be of type ArrayList but the user can actually pass a different List to the constructor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1469) DefaultDataBag assumes ArrayList as default List type

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883026#action_12883026 ] 

Daniel Dai commented on PIG-1469:
---------------------------------

+1. I am fine commit it as is since the change is trivial. 

> DefaultDataBag assumes ArrayList as default List type
> -----------------------------------------------------
>
>                 Key: PIG-1469
>                 URL: https://issues.apache.org/jira/browse/PIG-1469
>             Project: Pig
>          Issue Type: Bug
>          Components: data
>    Affects Versions: 0.8.0
>            Reporter: Gianmarco De Francisci Morales
>            Assignee: Gianmarco De Francisci Morales
>             Fix For: 0.8.0
>
>         Attachments: PIG-1469.patch
>
>
> In org.apache.pig.data.DefaultDataBag, the field mContents is assumed to be of type ArrayList but the user can actually pass a different List to the constructor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1469) DefaultDataBag assumes ArrayList as default List type

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882983#action_12882983 ] 

Hadoop QA commented on PIG-1469:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12448156/PIG-1469.patch
  against trunk revision 958053.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/334/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/334/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/334/console

This message is automatically generated.

> DefaultDataBag assumes ArrayList as default List type
> -----------------------------------------------------
>
>                 Key: PIG-1469
>                 URL: https://issues.apache.org/jira/browse/PIG-1469
>             Project: Pig
>          Issue Type: Bug
>          Components: data
>    Affects Versions: 0.8.0
>            Reporter: Gianmarco De Francisci Morales
>            Assignee: Gianmarco De Francisci Morales
>             Fix For: 0.8.0
>
>         Attachments: PIG-1469.patch
>
>
> In org.apache.pig.data.DefaultDataBag, the field mContents is assumed to be of type ArrayList but the user can actually pass a different List to the constructor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.