You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/10 10:39:41 UTC

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12780: [WIP] [BEAM-10857] Add Pubsub Avro table provider

piotr-szuberski edited a comment on pull request #12780:
URL: https://github.com/apache/beam/pull/12780#issuecomment-690145207


   @TheNeuralBit Could I ask you for review? I write some thoughts in the PR message - I wonder whether payloadFormat shouldn't be specified in TBLPROPERTIES instead of creating a separate class for every format? I'm planning to write PubsubProtoTableProvider next so there will be another class.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org