You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/23 23:55:54 UTC

[GitHub] [spark] zhengruifeng commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support

zhengruifeng commented on a change in pull request #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r361028836
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala
 ##########
 @@ -56,6 +56,8 @@ private[spark] trait DecisionTreeModel {
     rootNode.subtreeDepth
   }
 
+  var weightSum: Double
 
 Review comment:
   Where is this and above var `weightSum` computed or setted?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org