You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/11 17:31:19 UTC

[GitHub] [openwhisk] rabbah opened a new pull request #4855: Improvements to parameter encryption to support per-namespace keys

rabbah opened a new pull request #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855
 
 
   This PR extends @mcdan's work from #4756 to allow for per-namespace encryption keys. Each commit is an incremental refactoring which might help in understanding the progression.
   
   There are two singleton references to the encryption configuration - these can be replaced by identity-specific encryption configurations but requires additional work on extending the subject schema. I will stage that in a subsequent PR.
   
   The refactoring here is intended to be semantic preserving.
   
   ## Description
   <!--- Provide a detailed description of your changes. -->
   <!--- Include details of what problem you are solving and how your changes are tested. -->
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [x] I opened an issue to propose and discuss this change (#4854)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [x] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [x] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] rabbah commented on issue #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#issuecomment-612304452
 
 
   @mcdan might you have a chance to take a look at this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r391143903
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Parameter.scala
 ##########
 @@ -46,13 +46,6 @@ protected[core] class Parameters protected[entity] (private val params: Map[Para
       .foldLeft(0 B)(_ + _)
   }
 
-  protected[entity] def +(p: (ParameterName, ParameterValue)) = {
 
 Review comment:
   this is dead code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r391145334
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Parameter.scala
 ##########
 @@ -252,29 +268,6 @@ protected[core] object Parameters extends ArgNormalizer[Parameters] {
     ParameterValue(Option(v).getOrElse(JsNull), false, None))
   }
 
-  def readMergedList(value: JsValue): Parameters =
 
 Review comment:
   @mcdan by partitioning the arguments into locked and unlocked, I think the approach is simpler. The same information is crossing the message bus, but as two separate maps: the arguments, and the list of ones that are locked.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] codecov-io commented on issue #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#issuecomment-597985556
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=h1) Report
   > Merging [#4855](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/75f60aed1f61ad827570b5f335c733e14507bce9&el=desc) will **decrease** coverage by `6.12%`.
   > The diff coverage is `97.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk/pull/4855/graphs/tree.svg?width=650&height=150&src=pr&token=l0YmsiSAso)](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4855      +/-   ##
   ==========================================
   - Coverage   82.27%   76.15%   -6.13%     
   ==========================================
     Files         200      200              
     Lines        9277     9258      -19     
     Branches      376      377       +1     
   ==========================================
   - Hits         7633     7050     -583     
   - Misses       1644     2208     +564     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/openwhisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `91.25% <ø> (ø)` | |
   | [...he/openwhisk/core/entity/ParameterEncryption.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlckVuY3J5cHRpb24uc2NhbGE=) | `96.49% <96.55%> (+1.66%)` | :arrow_up: |
   | [...a/org/apache/openwhisk/core/entity/Parameter.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlci5zY2FsYQ==) | `94.36% <97.14%> (+5.59%)` | :arrow_up: |
   | [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `79.36% <100.00%> (ø)` | |
   | [...rg/apache/openwhisk/core/entity/WhiskPackage.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrUGFja2FnZS5zY2FsYQ==) | `96.66% <100.00%> (ø)` | |
   | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `85.33% <100.00%> (+0.09%)` | :arrow_up: |
   | [...enwhisk/core/loadBalancer/InvokerSupervision.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0ludm9rZXJTdXBlcnZpc2lvbi5zY2FsYQ==) | `85.31% <100.00%> (+0.10%)` | :arrow_up: |
   | [.../openwhisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.58% <100.00%> (+0.01%)` | :arrow_up: |
   | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [21 more](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=footer). Last update [75f60ae...a859976](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r391146172
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala
 ##########
 @@ -383,7 +384,9 @@ object WhiskAction extends DocumentFactory[WhiskAction] with WhiskEntityQueries[
       val stream = new ByteArrayInputStream(bytes)
       super.putAndAttach(
         db,
-        doc.copy(parameters = ParameterEncryption.lock(doc.parameters)).revision[WhiskAction](doc.rev),
+        doc
 
 Review comment:
   I preserved this copy call here and in packages but will need to later hoist it to where a user identity is available, in order to support per namespace encryption.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r391146899
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/actions/PrimitiveActions.scala
 ##########
 @@ -179,6 +179,7 @@ protected[actions] trait PrimitiveActions {
       waitForResponse.isDefined,
       args,
       action.parameters.initParameters,
+      action.parameters.lockedParameters(payload.map(_.fields.keySet).getOrElse(Set.empty)),
 
 Review comment:
   here, we exclude parameters that are overridden from the content body.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r391147538
 
 

 ##########
 File path: tests/src/test/scala/org/apache/openwhisk/core/controller/test/ActionsApiTests.scala
 ##########
 @@ -223,22 +224,22 @@ class ActionsApiTests extends ControllerTestCommon with WhiskActionsApi {
     }
   }
 
-//  it should "ignore updated field when updating action" in {
-//    implicit val tid = transid()
-//
-//    val action = WhiskAction(namespace, aname(), jsDefault(""))
-//    val dummyUpdated = WhiskEntity.currentMillis().toEpochMilli
-//
-//    val content = JsObject(
-//      "exec" -> JsObject("code" -> "".toJson, "kind" -> action.exec.kind.toJson),
-//      "updated" -> dummyUpdated.toJson)
-//
-//    Put(s"$collectionPath/${action.name}", content) ~> Route.seal(routes(creds)) ~> check {
-//      status should be(OK)
-//      val response = responseAs[WhiskAction]
-//      response.updated.toEpochMilli should be > dummyUpdated
-//    }
-//  }
+  it should "ignore updated field when updating action" in {
 
 Review comment:
   restored this test - not sure if it failed before - passed now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r391144086
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Parameter.scala
 ##########
 @@ -32,7 +32,7 @@ import scala.util.{Failure, Success, Try}
  * @param key the parameter name, assured to be non-null because it is a value
  * @param value the parameter value, assured to be non-null because it is a value
  */
-protected[core] class Parameters protected[entity] (private val params: Map[ParameterName, ParameterValue])
+protected[core] class Parameters protected[entity] (protected[entity] val params: Map[ParameterName, ParameterValue])
 
 Review comment:
   @mcdan this removes `getMap` and restricts access to the `entity` package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r391144654
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Parameter.scala
 ##########
 @@ -323,29 +293,30 @@ protected[core] object Parameters extends ArgNormalizer[Parameters] {
      * @return Parameters instance if parameters conforms to schema
      */
     def read(params: Vector[JsValue]) = Try {
-      new Parameters(
 
 Review comment:
   this change is mostly white space.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] codecov-io edited a comment on issue #4855: Improvements to parameter encryption to support per-namespace keys

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#issuecomment-597985556
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=h1) Report
   > Merging [#4855](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/75f60aed1f61ad827570b5f335c733e14507bce9&el=desc) will **decrease** coverage by `6.12%`.
   > The diff coverage is `97.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk/pull/4855/graphs/tree.svg?width=650&height=150&src=pr&token=l0YmsiSAso)](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4855      +/-   ##
   ==========================================
   - Coverage   82.27%   76.15%   -6.13%     
   ==========================================
     Files         200      200              
     Lines        9277     9258      -19     
     Branches      376      377       +1     
   ==========================================
   - Hits         7633     7050     -583     
   - Misses       1644     2208     +564     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/openwhisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `91.25% <ø> (ø)` | |
   | [...he/openwhisk/core/entity/ParameterEncryption.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlckVuY3J5cHRpb24uc2NhbGE=) | `96.49% <96.55%> (+1.66%)` | :arrow_up: |
   | [...a/org/apache/openwhisk/core/entity/Parameter.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlci5zY2FsYQ==) | `94.36% <97.14%> (+5.59%)` | :arrow_up: |
   | [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `79.36% <100.00%> (ø)` | |
   | [...rg/apache/openwhisk/core/entity/WhiskPackage.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrUGFja2FnZS5zY2FsYQ==) | `96.66% <100.00%> (ø)` | |
   | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `85.33% <100.00%> (+0.09%)` | :arrow_up: |
   | [...enwhisk/core/loadBalancer/InvokerSupervision.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0ludm9rZXJTdXBlcnZpc2lvbi5zY2FsYQ==) | `85.31% <100.00%> (+0.10%)` | :arrow_up: |
   | [.../openwhisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.58% <100.00%> (+0.01%)` | :arrow_up: |
   | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [21 more](https://codecov.io/gh/apache/openwhisk/pull/4855/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=footer). Last update [75f60ae...a859976](https://codecov.io/gh/apache/openwhisk/pull/4855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services