You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/05/25 08:56:19 UTC

[GitHub] [helix] richardstartin opened a new issue, #2117: ClusterStatusMonitor is a bottleneck in BestPossibleStateCalcStage.process

richardstartin opened a new issue, #2117:
URL: https://github.com/apache/helix/issues/2117

   This profile was taken from an Apache Pinot controller:
   <img width="1425" alt="Screenshot 2022-05-25 at 09 53 04" src="https://user-images.githubusercontent.com/16439049/170222935-5b9111b3-1373-4e71-bcc1-edf7be2db84a.png">
   
   About 18% of the samples were in `ClusterStatusMonitor.setPerInstanceResourceStatus` (zoomed in)
   
   <img width="1430" alt="Screenshot 2022-05-25 at 09 53 22" src="https://user-images.githubusercontent.com/16439049/170223015-611a084a-3f96-40d5-b5ec-e639886ccb68.png">
   
   The root causes are:
   
   * inefficient hashCode implementation in `PerInstanceResourceMonitor$BeanName`
   * doing twice the work in `ClusterStatusMonitor.setPerInstanceResourceStatus` because `containsKey` is called before `get`, when the same effect could be achieved efficiently by `computeIfAbsent`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] desaikomal commented on issue #2117: ClusterStatusMonitor is a bottleneck in BestPossibleStateCalcStage.process

Posted by GitBox <gi...@apache.org>.
desaikomal commented on issue #2117:
URL: https://github.com/apache/helix/issues/2117#issuecomment-1137431042

   Richard, great finds. If you don't mind asking me, what profiling tool are you using?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] junkaixue closed issue #2117: ClusterStatusMonitor is a bottleneck in BestPossibleStateCalcStage.process

Posted by GitBox <gi...@apache.org>.
junkaixue closed issue #2117: ClusterStatusMonitor is a bottleneck in BestPossibleStateCalcStage.process
URL: https://github.com/apache/helix/issues/2117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] richardstartin commented on issue #2117: ClusterStatusMonitor is a bottleneck in BestPossibleStateCalcStage.process

Posted by GitBox <gi...@apache.org>.
richardstartin commented on issue #2117:
URL: https://github.com/apache/helix/issues/2117#issuecomment-1137453748

   > Richard, great finds. If you don't mind asking me, what profiling tool are you using?
   
   I'm using JFR, visualised with JMC


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org