[GitHub] [doris] zhannngchen commented on a diff in pull request #13409: [improvement](compaction) delete num based compaction policy

[GitBox <gi...@apache.org>]

zhannngchen commented on code in PR #13409:
URL: https://github.com/apache/doris/pull/13409#discussion_r997779090


##########
be/src/olap/cumulative_compaction_policy.h:
##########
@@ -248,13 +193,7 @@ class CumulativeCompactionPolicyFactory {
 public:
     /// Static factory function. It can product different policy according to the `policy` parameter and use tablet ptr
     /// to construct the policy. Now it can product size based and num based policies.
-    static std::shared_ptr<CumulativeCompactionPolicy> create_cumulative_compaction_policy(
-            std::string policy);
-
-private:
-    /// It is a static function to help to check the policy config and convert to CompactionPolicy enum variable
-    static void _parse_cumulative_compaction_policy(std::string policy,
-                                                    CompactionPolicy* policy_type);
+    static std::shared_ptr<CumulativeCompactionPolicy> create_cumulative_compaction_policy();

Review Comment:
   The comment of this method should also be updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org