[GitHub] [superset] hwmarkcheng commented on pull request #25192: feat: Add slice_id to query object

["hwmarkcheng (via GitHub)" <gi...@apache.org>]

hwmarkcheng commented on PR #25192:
URL: https://github.com/apache/superset/pull/25192#issuecomment-1712191153

   
   Hey @villebro! 
   
   Thank you for your review! 
   
   Yes, `slice_id` is in `query_context`, however it seems that most query actions for the BaseDatasource class (which contains sql_query_mutator) uses `query_obj` as the parameter. 
   
   We traced back to where `query_object` is [created](https://github.com/apache/superset/blob/f0c5b67515a076956771b6d6abc2e61c024bf763/superset/common/query_context_factory.py#L72) to add this `slice_id` in. Wondering if you can clarify on the harmonization part, I think given this `slice_id ` is only passed in through it's creation in `query_context_factory/query_object_factory`? 
   
   Ah we haven't dived too much into the frontend portion of the code. Would the ask be to add something like a #slice_id into the chart editor UI so that users can easily get the ID of the chart?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org