You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2014/03/20 22:32:30 UTC
Review Request 19496: ACCUMULO-2487 match Value implementation to javadocs.
check for null args.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19496/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-2487
https://issues.apache.org/jira/browse/ACCUMULO-2487
Repository: accumulo
Description
-------
Updates Value() to create an empty backing array. Makes methods that touch the backing array reject nulls proactively. Changed some internal checks to asserts since there ought not be a way to make the backing array null.
Diffs
-----
core/src/main/java/org/apache/accumulo/core/data/Value.java 39ebbd0
core/src/test/java/org/apache/accumulo/core/data/ValueTest.java 9b68222
Diff: https://reviews.apache.org/r/19496/diff/
Testing
-------
existing and new unit tests pass, with the exception of changing some for the default constructor since they matched the previous implementation rather than the javadoc.
mvn verify in progress.
Thanks,
Sean Busbey
Re: Review Request 19496: ACCUMULO-2487 match Value implementation to
javadocs. check for null args.
Posted by ke...@deenlo.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19496/#review38177
-----------------------------------------------------------
Ship it!
Ship It!
- kturner
On March 20, 2014, 9:32 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19496/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 9:32 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2487
> https://issues.apache.org/jira/browse/ACCUMULO-2487
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Updates Value() to create an empty backing array. Makes methods that touch the backing array reject nulls proactively. Changed some internal checks to asserts since there ought not be a way to make the backing array null.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/data/Value.java 39ebbd0
> core/src/test/java/org/apache/accumulo/core/data/ValueTest.java 9b68222
>
> Diff: https://reviews.apache.org/r/19496/diff/
>
>
> Testing
> -------
>
> existing and new unit tests pass, with the exception of changing some for the default constructor since they matched the previous implementation rather than the javadoc.
>
> mvn verify in progress.
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 19496: ACCUMULO-2487 match Value implementation to
javadocs. check for null args.
Posted by Bill Slacum <uj...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19496/#review38175
-----------------------------------------------------------
Ship it!
We could consider use of one of the many @NotNull annotations in method signatures. Not a deal breaker since it's documented.
- Bill Slacum
On March 20, 2014, 9:32 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19496/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 9:32 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2487
> https://issues.apache.org/jira/browse/ACCUMULO-2487
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Updates Value() to create an empty backing array. Makes methods that touch the backing array reject nulls proactively. Changed some internal checks to asserts since there ought not be a way to make the backing array null.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/data/Value.java 39ebbd0
> core/src/test/java/org/apache/accumulo/core/data/ValueTest.java 9b68222
>
> Diff: https://reviews.apache.org/r/19496/diff/
>
>
> Testing
> -------
>
> existing and new unit tests pass, with the exception of changing some for the default constructor since they matched the previous implementation rather than the javadoc.
>
> mvn verify in progress.
>
>
> Thanks,
>
> Sean Busbey
>
>