You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Beam JIRA Bot (Jira)" <ji...@apache.org> on 2020/08/18 17:07:15 UTC

[jira] [Updated] (BEAM-3640) Checkstyle enforcement of blank lines

     [ https://issues.apache.org/jira/browse/BEAM-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Beam JIRA Bot updated BEAM-3640:
--------------------------------
    Labels: stale-P2  (was: )

> Checkstyle enforcement of blank lines
> -------------------------------------
>
>                 Key: BEAM-3640
>                 URL: https://issues.apache.org/jira/browse/BEAM-3640
>             Project: Beam
>          Issue Type: Task
>          Components: build-system
>            Reporter: Daniel Kulp
>            Priority: P2
>              Labels: stale-P2
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Checkstyle has a rule (EmptyLineSeparator) we currently don't use to enforce the use of blank lines in various places.   In order to reduce the noise in reviews of PR's, I like to start using it.
> This will likely be accomplished via a series of PR's.   Just adding the default EmptyLineSeparator to the checkstyle rules results in a THOUSANDS of violations which would be hard to review.   I will likely enable it for one token type at a time, fix the violations on that particular token type, submit, add then next token type, etc... That should  (hopefully) keep each PR down to something that can reasonably be reviewed. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)