You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2018/11/13 21:29:57 UTC
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11926
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Add a handy tool to collapse threads in pstacks
This commit imports a very useful tool that summarizes/collapses
threads from gdb pstacks. I found it very useful in analyzing
pstacks with large number of threads, specially in Impala's context.
Credit to the original author at https://poormansprofiler.org/
(Slightly modified for better input handling).
Example Usages:
---------------
summarize-pstacks foo.pstack
summarize-pstacks foo_*.pstack
cat foo.pstack | summarize-pstacks
cat foo_*.pstack | summarize-pstacks
Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
---
A bin/summarize-pstacks
1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/11926/1
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/1476/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 00:17:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3508/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 00:53:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 05:05:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Add a handy tool to collapse threads in pstacks
This commit imports a very useful tool that summarizes/collapses
threads from gdb pstacks. I found it very useful in analyzing
pstacks with large number of threads, specially in Impala's context.
Credit to the original author at https://poormansprofiler.org/
(Slightly modified for better input handling).
Example Usages:
---------------
summarize-pstacks foo.pstack
summarize-pstacks foo_*.pstack
cat foo.pstack | summarize-pstacks
cat foo_*.pstack | summarize-pstacks
Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Reviewed-on: http://gerrit.cloudera.org:8080/11926
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/rat_exclude_files.txt
A bin/summarize-pstacks
2 files changed, 43 insertions(+), 0 deletions(-)
Approvals:
Bharath Vissapragada: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 4
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1477/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 01:27:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 1:
Unfortunately we probably need to clarify the license for this - I think we probably need to reach out to Domas to clarify that it's public domain.
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Nov 2018 00:23:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11926/1/bin/summarize-pstacks
File bin/summarize-pstacks:
http://gerrit.cloudera.org:8080/#/c/11926/1/bin/summarize-pstacks@24
PS1, Line 24: summarize-pstack
This should be summarize-pstacks (here and below). Will fix it in the next rev along with other comments.
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 22:15:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 2: Code-Review+2
LGTM once you figure out the RAT issue.
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 00:25:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 3:
Looks like RAT doesn't work with non-Apache licenses. So I added it to the excludes file. We took a similar approach for another file with BSD 3-Clause license. I'm hoping that's fine.
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 00:51:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 2:
Reached out to Mark Callaghan via email. He was generous enough to give this script a 2-clause BSD license which is compatible with Apache 2.0. I retained the copyright accordingly. The original source code is at https://github.com/mdcallag/mytools/blob/master/scripts/pmp.sh
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 23:39:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11926
to look at the new patch set (#3).
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Add a handy tool to collapse threads in pstacks
This commit imports a very useful tool that summarizes/collapses
threads from gdb pstacks. I found it very useful in analyzing
pstacks with large number of threads, specially in Impala's context.
Credit to the original author at https://poormansprofiler.org/
(Slightly modified for better input handling).
Example Usages:
---------------
summarize-pstacks foo.pstack
summarize-pstacks foo_*.pstack
cat foo.pstack | summarize-pstacks
cat foo_*.pstack | summarize-pstacks
Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
---
M bin/rat_exclude_files.txt
A bin/summarize-pstacks
2 files changed, 43 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/11926/3
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 3: Code-Review+2
Carrying +2. (RAT check passes locally on the last PS)
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 00:53:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1358/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 22:21:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 )
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Patch Set 1:
Yes. I couldn't track down Domas' email. But I've sent out an email to Mark Callaghan who collaborated with Domas on this work.
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Nov 2018 00:26:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11926
to look at the new patch set (#2).
Change subject: Add a handy tool to collapse threads in pstacks
......................................................................
Add a handy tool to collapse threads in pstacks
This commit imports a very useful tool that summarizes/collapses
threads from gdb pstacks. I found it very useful in analyzing
pstacks with large number of threads, specially in Impala's context.
Credit to the original author at https://poormansprofiler.org/
(Slightly modified for better input handling).
Example Usages:
---------------
summarize-pstacks foo.pstack
summarize-pstacks foo_*.pstack
cat foo.pstack | summarize-pstacks
cat foo_*.pstack | summarize-pstacks
Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
---
A bin/summarize-pstacks
1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/11926/2
--
To view, visit http://gerrit.cloudera.org:8080/11926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0d00f7cea5fe01ff8b2511f4e04db5d5ad1c82f4
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>