You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by br...@apache.org on 2004/01/22 15:46:19 UTC

cvs commit: xml-forrest/src/core/context dtd.xmap

brondsem    2004/01/22 06:46:19

  Modified:    src/core/context dtd.xmap
  Log:
  hope this is right.  it fixed the broken dtd links for me
  
  Revision  Changes    Path
  1.3       +2 -2      xml-forrest/src/core/context/dtd.xmap
  
  Index: dtd.xmap
  ===================================================================
  RCS file: /home/cvs/xml-forrest/src/core/context/dtd.xmap,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- dtd.xmap	26 Nov 2003 09:15:31 -0000	1.2
  +++ dtd.xmap	22 Jan 2004 14:46:19 -0000	1.3
  @@ -25,7 +25,7 @@
       <map:pipeline>
   
         <map:match pattern="**.dtdx.xml">
  -        <map:generate type="nekodtd" src="{forrest:home}/context/resources/schema/dtd/{1}.dtd">
  +        <map:generate type="nekodtd" src="{forrest:home}/resources/schema/dtd/{1}.dtd">
             <map:parameter name="config-class" value="org.cyberneko.dtd.DTDConfiguration" />
           </map:generate>
           <map:transform src="{forrest:stylesheets}/dtdx2flat.xsl" />
  
  
  

Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Nicola Ken Barozzi <ni...@apache.org>.
Juan Jose Pablos wrote:

> Nicola Ken Barozzi wrote:
> 
>> Juan Jose Pablos wrote:
>>
>>> Dave,
>>>
>>> The truth is that things are too messy.
>>>
>>> what I do not understant is why forrest_home is on 
>>> xml-forrest/build/dist/shbat in the first place.
>>
>> I already explained it to you in the last messages. What part did you 
>> not understand?
> 
> no no, you did not explain why FORREST_HOME is under build/dist/shbat 
> instead. 

So that users don't need to change their FORREST_HOME.

> putting libraries under WEB-INF/lib or modifying cocoon.xconf 
> does not requiere to thave FORREST_HOME under build/dist/shbat.
>
>>> I rather than change to xml-forrest/src/core.
>>
>> I'd like too, but there are two issues to be resolved. The filtering 
>> and the libraries. It can be fixed, but someone has to do it.
> 
> well I tried, but things are too messy, I am thinking about:
> 
> 
> Either create a FORREST_ROOT to point to ../../../build/dist/shbat 
> (xml-forrest)
> 
> move FORREST_HOME to  ../../../build/dist/shbat (xml-forrest)
> 
> WDYT?

I understand your concerns, and I agree with them, but I think that this 
is a half-baked solution. The goal is not to move away Forrest_home, but 
to make it so that we don't need a build step at all. We can get away 
with a final solution without needing these hacks, so IMO we should 
pursue that instead.

  - make jetty run Forrest without needing that the libraries are in
    WEB-INF
  - make it so that cocoon.xconf doesn't need filtering

In any way, I'll try to see what I can do for this in the next days, and 
keep your suggestions in my head, because maybe they will nevertheless 
come in handy.

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Juan Jose Pablos <ch...@che-che.com>.
Nicola Ken Barozzi wrote:
> Juan Jose Pablos wrote:
> 
>> Dave,
>>
>> The truth is that things are too messy.
>>
>> what I do not understant is why forrest_home is on 
>> xml-forrest/build/dist/shbat in the first place.
> 
> 
> I already explained it to you in the last messages. What part did you 
> not understand?
> 

no no, you did not explain why FORREST_HOME is under build/dist/shbat 
instead. putting libraries under WEB-INF/lib or modifying cocoon.xconf 
does not requiere to thave FORREST_HOME under build/dist/shbat.



>> I rather than change to xml-forrest/src/core.
> 
> 
> I'd like too, but there are two issues to be resolved. The filtering and 
> the libraries. It can be fixed, but someone has to do it.
> 

well I tried, but things are too messy, I am thinking about:


Either create a FORREST_ROOT to point to ../../../build/dist/shbat 
(xml-forrest)

move FORREST_HOME to  ../../../build/dist/shbat (xml-forrest)


WDYT?

Cheche


Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Nicola Ken Barozzi <ni...@apache.org>.
Juan Jose Pablos wrote:
> Dave,
> 
> The truth is that things are too messy.
> 
> what I do not understant is why forrest_home is on 
> xml-forrest/build/dist/shbat in the first place.

I already explained it to you in the last messages. What part did you 
not understand?

> I rather than change to xml-forrest/src/core.

I'd like too, but there are two issues to be resolved. The filtering and 
the libraries. It can be fixed, but someone has to do it.

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Juan Jose Pablos <ch...@che-che.com>.
Dave,

The truth is that things are too messy.


what I do not understant is why forrest_home is on 
xml-forrest/build/dist/shbat in the first place.

I rather than change to xml-forrest/src/core.

I would be quite happy to use just xml-forrest/ otherwise people get 
confused for something so trivial...

WDYT?

Cheche

Nicola Ken Barozzi wrote:
> Dave Brondsema wrote:
> 
> ...
> 
>>> If it is, then look in the cocoon.xconf in the build dir you are using.
>>> If the forrest.home value you have there is wrong, the build is broken.
>>
>>
>> Here are the values in all the cocoon.xconf files in my build dir
>>
>> build/dist/shbat/context/WEB-INF/cocoon.xconf:
>>     <home>@forrest.home@</home>
> 
> 
> It's wrong. Ant should have changed it to point to FORREST_HOME.
> 
> Try reverting your build changes, and see if it works.
> 
> 



Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Dave Brondsema <da...@brondsema.net>.
On Thu, 22 Jan 2004, Nicola Ken Barozzi wrote:

> Dave Brondsema wrote:
>
> ...
> >>If it is, then look in the cocoon.xconf in the build dir you are using.
> >>If the forrest.home value you have there is wrong, the build is broken.
> >
> > Here are the values in all the cocoon.xconf files in my build dir
> >
> > build/dist/shbat/context/WEB-INF/cocoon.xconf:
> > 	<home>@forrest.home@</home>
>
> It's wrong. Ant should have changed it to point to FORREST_HOME.

It seems that none of the tokens in this file have been replaced.

>
> Try reverting your build changes, and see if it works.
>

I just did a clean build and I don't have any significant local
modifications from CVS HEAD.

-- 
Dave Brondsema
dave@brondsema.net
http://www.brondsema.net - personal
http://www.splike.com - programming
http://csx.calvin.edu - Calvin club

Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Nicola Ken Barozzi <ni...@apache.org>.
Dave Brondsema wrote:

...
>>If it is, then look in the cocoon.xconf in the build dir you are using.
>>If the forrest.home value you have there is wrong, the build is broken.
> 
> Here are the values in all the cocoon.xconf files in my build dir
> 
> build/dist/shbat/context/WEB-INF/cocoon.xconf:
> 	<home>@forrest.home@</home>

It's wrong. Ant should have changed it to point to FORREST_HOME.

Try reverting your build changes, and see if it works.


-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Dave Brondsema <da...@brondsema.net>.
On Thu, 22 Jan 2004, Nicola Ken Barozzi wrote:

> Dave Brondsema wrote:
>
> > On Thu, 22 Jan 2004, Nicola Ken Barozzi wrote:
> >
> >
> >>brondsem@apache.org wrote:
> >>
> >>
> >>>brondsem    2004/01/22 06:46:19
> ...
> >>>         <map:match pattern="**.dtdx.xml">
> >>>  -        <map:generate type="nekodtd" src="{forrest:home}/context/resources/schema/dtd/{1}.dtd">
> >>>  +        <map:generate type="nekodtd" src="{forrest:home}/resources/schema/dtd/{1}.dtd">
> >>
> >>I assure you that on the Forrest I have built some days ago the dtds are
> >>here:
> >>
> >>   xml-forrest\build\dist\shbat\context\resources\schema\dtd
> >>
> >>Since {forrest:home} == xml-forrest\build\dist\shbat
> >>
> >>   {forrest:home}/context/resources/schema/dtd/{1}.dtd
> >>
> >>is correct.
> >>
> >>Maybe the build change is not right.
> >
> > The errors I was getting were looking for the files in
> > xml-forrest/build/webapp/context/resources (perhaps forrest:home is
> > wrong?)
>
> Check that FORREST_HOME is set to *\xml-forrest\build\dist\shbat

Yup.

> If it is, then look in the cocoon.xconf in the build dir you are using.
> If the forrest.home value you have there is wrong, the build is broken.

Here are the values in all the cocoon.xconf files in my build dir

build/dist/shbat/context/WEB-INF/cocoon.xconf:
	<home>@forrest.home@</home>

build/webapp/WEB-INF/cocoon.xconf:
	<home>.</home>

And I checked and the forrest.bat wrapper does pass -Dforrest.home
properly.

-- 
Dave Brondsema
dave@brondsema.net
http://www.brondsema.net - personal
http://www.splike.com - programming
http://csx.calvin.edu - Calvin club

Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Nicola Ken Barozzi <ni...@apache.org>.
Dave Brondsema wrote:

> On Thu, 22 Jan 2004, Nicola Ken Barozzi wrote:
> 
> 
>>brondsem@apache.org wrote:
>>
>>
>>>brondsem    2004/01/22 06:46:19
...
>>>         <map:match pattern="**.dtdx.xml">
>>>  -        <map:generate type="nekodtd" src="{forrest:home}/context/resources/schema/dtd/{1}.dtd">
>>>  +        <map:generate type="nekodtd" src="{forrest:home}/resources/schema/dtd/{1}.dtd">
>>
>>I assure you that on the Forrest I have built some days ago the dtds are
>>here:
>>
>>   xml-forrest\build\dist\shbat\context\resources\schema\dtd
>>
>>Since {forrest:home} == xml-forrest\build\dist\shbat
>>
>>   {forrest:home}/context/resources/schema/dtd/{1}.dtd
>>
>>is correct.
>>
>>Maybe the build change is not right.
> 
> The errors I was getting were looking for the files in
> xml-forrest/build/webapp/context/resources (perhaps forrest:home is
> wrong?)

Check that FORREST_HOME is set to *\xml-forrest\build\dist\shbat

If it is, then look in the cocoon.xconf in the build dir you are using.
If the forrest.home value you have there is wrong, the build is broken.

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Dave Brondsema <da...@brondsema.net>.
On Thu, 22 Jan 2004, Nicola Ken Barozzi wrote:

>
> brondsem@apache.org wrote:
>
> > brondsem    2004/01/22 06:46:19
> >
> >   Modified:    src/core/context dtd.xmap
> >   Log:
> >   hope this is right.  it fixed the broken dtd links for me
> >
> >   Revision  Changes    Path
> >   1.3       +2 -2      xml-forrest/src/core/context/dtd.xmap
> >
> >   Index: dtd.xmap
> >   ===================================================================
> >   RCS file: /home/cvs/xml-forrest/src/core/context/dtd.xmap,v
> >   retrieving revision 1.2
> >   retrieving revision 1.3
> >   diff -u -r1.2 -r1.3
> >   --- dtd.xmap	26 Nov 2003 09:15:31 -0000	1.2
> >   +++ dtd.xmap	22 Jan 2004 14:46:19 -0000	1.3
> >   @@ -25,7 +25,7 @@
> >        <map:pipeline>
> >
> >          <map:match pattern="**.dtdx.xml">
> >   -        <map:generate type="nekodtd" src="{forrest:home}/context/resources/schema/dtd/{1}.dtd">
> >   +        <map:generate type="nekodtd" src="{forrest:home}/resources/schema/dtd/{1}.dtd">
>
> I assure you that on the Forrest I have built some days ago the dtds are
> here:
>
>    xml-forrest\build\dist\shbat\context\resources\schema\dtd
>
> Since {forrest:home} == xml-forrest\build\dist\shbat
>
>    {forrest:home}/context/resources/schema/dtd/{1}.dtd
>
> is correct.
>
> Maybe the build change is not right.
>

The errors I was getting were looking for the files in
xml-forrest/build/webapp/context/resources (perhaps forrest:home is
wrong?)

-- 
Dave Brondsema
dave@brondsema.net
http://www.brondsema.net - personal
http://www.splike.com - programming
http://csx.calvin.edu - Calvin club

Re: cvs commit: xml-forrest/src/core/context dtd.xmap

Posted by Nicola Ken Barozzi <ni...@apache.org>.
brondsem@apache.org wrote:

> brondsem    2004/01/22 06:46:19
> 
>   Modified:    src/core/context dtd.xmap
>   Log:
>   hope this is right.  it fixed the broken dtd links for me
>   
>   Revision  Changes    Path
>   1.3       +2 -2      xml-forrest/src/core/context/dtd.xmap
>   
>   Index: dtd.xmap
>   ===================================================================
>   RCS file: /home/cvs/xml-forrest/src/core/context/dtd.xmap,v
>   retrieving revision 1.2
>   retrieving revision 1.3
>   diff -u -r1.2 -r1.3
>   --- dtd.xmap	26 Nov 2003 09:15:31 -0000	1.2
>   +++ dtd.xmap	22 Jan 2004 14:46:19 -0000	1.3
>   @@ -25,7 +25,7 @@
>        <map:pipeline>
>    
>          <map:match pattern="**.dtdx.xml">
>   -        <map:generate type="nekodtd" src="{forrest:home}/context/resources/schema/dtd/{1}.dtd">
>   +        <map:generate type="nekodtd" src="{forrest:home}/resources/schema/dtd/{1}.dtd">

I assure you that on the Forrest I have built some days ago the dtds are 
here:

   xml-forrest\build\dist\shbat\context\resources\schema\dtd

Since {forrest:home} == xml-forrest\build\dist\shbat

   {forrest:home}/context/resources/schema/dtd/{1}.dtd

is correct.

Maybe the build change is not right.

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------