You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "utkarsharma2 (via GitHub)" <gi...@apache.org> on 2023/04/14 03:41:19 UTC

[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #30595: DynamoDBHook - waiter_path() to consider `resource_type` or `client_type`

utkarsharma2 commented on code in PR #30595:
URL: https://github.com/apache/airflow/pull/30595#discussion_r1166247645


##########
tests/providers/amazon/aws/hooks/test_dynamodb.py:
##########
@@ -55,3 +56,9 @@ def test_insert_batch_items_dynamodb_table(self):
 
         table.meta.client.get_waiter("table_exists").wait(TableName="test_airflow")
         assert table.item_count == 10
+
+    @mock.patch("pathlib.Path.exists", return_value=True)
+    def test_waiter_path_generated_from_resource_type(self, _):
+        hook = DynamoDBHook(aws_conn_id="aws_default")
+        path = hook.waiter_path
+        assert path

Review Comment:
   @o-nikolas Asserted the expected path 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org