You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/01 13:32:40 UTC

[GitHub] [flink] zhuyufeng0809 opened a new pull request, #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

zhuyufeng0809 opened a new pull request, #19992:
URL: https://github.com/apache/flink/pull/19992

   ## What is the purpose of the change
   
   Fix log information typo in sanityCheckJvmOverhead method of ProcessMemoryUtils Class
   
   ## Brief change log
   
   modified the case of a string word in sanityCheckJvmOverhead method of ProcessMemoryUtils Class
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] Myasuka commented on pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19992:
URL: https://github.com/apache/flink/pull/19992#issuecomment-1158395472

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] Myasuka commented on pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19992:
URL: https://github.com/apache/flink/pull/19992#issuecomment-1172323171

   @zhuyufeng0809 Why you closed this PR? I have already accepted this PR and it needs a green CI to make it merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19992:
URL: https://github.com/apache/flink/pull/19992#issuecomment-1157539928

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "78be7d1418ac2da22e289046f63fbfa7da9bb2f9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "78be7d1418ac2da22e289046f63fbfa7da9bb2f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78be7d1418ac2da22e289046f63fbfa7da9bb2f9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zhuyufeng0809 commented on pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
zhuyufeng0809 commented on PR #19992:
URL: https://github.com/apache/flink/pull/19992#issuecomment-1172354378

   emmmmm I click the restore button, which seems to restore the branch I deleted


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] Myasuka commented on pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19992:
URL: https://github.com/apache/flink/pull/19992#issuecomment-1178892482

   Just merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] Myasuka merged pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
Myasuka merged PR #19992:
URL: https://github.com/apache/flink/pull/19992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zhuyufeng0809 commented on pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
zhuyufeng0809 commented on PR #19992:
URL: https://github.com/apache/flink/pull/19992#issuecomment-1157540503

   Hi @Myasuka , could you help me to review this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zhuyufeng0809 closed pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
zhuyufeng0809 closed pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class
URL: https://github.com/apache/flink/pull/19992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] Myasuka commented on pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19992:
URL: https://github.com/apache/flink/pull/19992#issuecomment-1173253243

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zhuyufeng0809 commented on pull request #19992: [hotfix][Runtime/Configuration] Fix typo in ProcessMemoryUtils Class

Posted by GitBox <gi...@apache.org>.
zhuyufeng0809 commented on PR #19992:
URL: https://github.com/apache/flink/pull/19992#issuecomment-1178862868

   Hi @Myasuka , can this PR be merged or need do something else?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org