You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ps...@apache.org on 2015/12/10 04:33:42 UTC
svn commit: r1719007 -
/commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java
Author: psteitz
Date: Thu Dec 10 03:33:41 2015
New Revision: 1719007
URL: http://svn.apache.org/viewvc?rev=1719007&view=rev
Log:
Remove trailing spaces and re-ordered imports.
Modified:
commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java
Modified: commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java?rev=1719007&r1=1719006&r2=1719007&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java (original)
+++ commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java Thu Dec 10 03:33:41 2015
@@ -17,11 +17,6 @@
package org.apache.commons.dbcp2;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-import org.apache.commons.pool2.impl.BaseObjectPoolConfig;
-import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
-
import java.io.ByteArrayInputStream;
import java.nio.charset.StandardCharsets;
import java.sql.Connection;
@@ -42,6 +37,11 @@ import javax.naming.RefAddr;
import javax.naming.Reference;
import javax.naming.spi.ObjectFactory;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.commons.pool2.impl.BaseObjectPoolConfig;
+import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
+
/**
* <p>JNDI object factory that creates an instance of
* <code>BasicDataSource</code> that has been configured based on the
@@ -288,7 +288,7 @@ public class BasicDataSourceFactory impl
private void validatePropertyNames(Reference ref, Name name, List<String> warnings,
List<String> infoMessages) {
final List<String> allPropsAsList = Arrays.asList(ALL_PROPERTIES);
- final String nameString = name != null ? "Name = " + name.toString() + " " : "";
+ final String nameString = name != null ? "Name = " + name.toString() + " " : "";
if (NUPROP_WARNTEXT!=null && !NUPROP_WARNTEXT.keySet().isEmpty()) {
for (String propertyName : NUPROP_WARNTEXT.keySet()) {
final RefAddr ra = ref.get(propertyName);
@@ -519,7 +519,7 @@ public class BasicDataSourceFactory impl
if (value != null) {
dataSource.setLogAbandoned(Boolean.valueOf(value).booleanValue());
}
-
+
value = properties.getProperty(PROP_ABANDONEDUSAGETRACKING);
if (value != null) {
dataSource.setAbandonedUsageTracking(Boolean.valueOf(value).booleanValue());