[GitHub] [atlas] sidharthkmishra commented on a change in pull request #127: Update objectPrefix isUnique for aws_s3_v2_directory to false

[GitBox <gi...@apache.org>]

sidharthkmishra commented on a change in pull request #127:
URL: https://github.com/apache/atlas/pull/127#discussion_r591753655



##########
File path: addons/models/3000-Cloud/patches/007-s3_v2_update_attributes.json
##########
@@ -0,0 +1,23 @@
+{
+  "patches": [
+    {
+      "id": "TYPEDEF_PATCH_3000_007_001",
+      "description": "Update objectPrefix isUnique for aws_s3_v2_directory to false",
+      "action": "UPDATE_ATTRIBUTE",
+      "typeName": "aws_s3_v2_directory",
+      "applyToVersion": "1.1",
+      "updateToVersion": "1.2",

Review comment:
       Please change the aws_s3_v2_directory's objectPrefix attribute at 3030-aws_s3_v2_typedefs.json file too and change the typeVersion. The patch file will ensure the model upgrade for older version and the new installation will be created with newer version from 3030-aws_s3_v2_typedefs.json 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org