[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #58: [FLINK-16003][Connectors/Kinesis] Log non-retriable Kinesis exceptions from getRecords

["dannycranmer (via GitHub)" <gi...@apache.org>]

dannycranmer commented on code in PR #58:
URL: https://github.com/apache/flink-connector-aws/pull/58#discussion_r1140050195


##########
flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java:
##########
@@ -313,6 +313,9 @@ public GetRecordsResult getRecords(String shardIterator, int maxRecordsToGet)
                 } else {
                     throw ex;
                 }
+            } catch (RuntimeException ex) {
+                LOG.error(ex.getClass().getName() + ": " + ex.getMessage());

Review Comment:
   Why not `LOG.error(ex)`, or something with a meaningful message `LOG.error("Encountered non-recoverable error while invoking getRecords.", ex);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org