You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/27 21:47:35 UTC
[GitHub] [arrow] wjones127 opened a new pull request, #15099: MINOR: support older versions of CURL in release scripts
wjones127 opened a new pull request, #15099:
URL: https://github.com/apache/arrow/pull/15099
The `--retry-all-errors` parameter is available starting in 7.71.0 - June 24 2020, while the latest curl I could install in Ubuntu 20.04 from apt-get is 7.68.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #15099: MINOR: support older versions of CURL in release scripts
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #15099:
URL: https://github.com/apache/arrow/pull/15099#discussion_r1057933823
##########
dev/release/download_rc_binaries.py:
##########
@@ -203,7 +203,9 @@ def _download_file(self, dest, asset):
"--header",
"Accept: application/octet-stream",
# Also retry 403s
- "--retry-all-errors",
+ "--retry",
+ "5",
Review Comment:
They are redundant because `download_url()` already have them.
##########
dev/release/download_rc_binaries.py:
##########
@@ -203,7 +203,9 @@ def _download_file(self, dest, asset):
"--header",
"Accept: application/octet-stream",
# Also retry 403s
- "--retry-all-errors",
+ "--retry",
+ "5",
+ "--fail"
Review Comment:
How about retrying without `--retry-all-errors` when `_download_url()` with `--retry-all-errors` is failed?
```python
try:
self._download_url(..., "--retry-all-errors", ...)
except ...:
self._download_url(...)
```
Or we can check `curl` version to confirm whether we can use `--retry-all-errors` or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #15099: MINOR: [Release] Support older versions of CURL in GitHub downloader
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #15099:
URL: https://github.com/apache/arrow/pull/15099#issuecomment-1366980866
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d587f93c794b45148e85ad5196f86304...40a456d8d9b74153a587efc7a459f407/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #15099: MINOR: [Release] Support older versions of CURL in GitHub downloader
Posted by GitBox <gi...@apache.org>.
kou merged PR #15099:
URL: https://github.com/apache/arrow/pull/15099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on a diff in pull request #15099: MINOR: support older versions of CURL in release scripts
Posted by GitBox <gi...@apache.org>.
wjones127 commented on code in PR #15099:
URL: https://github.com/apache/arrow/pull/15099#discussion_r1057952053
##########
dev/release/download_rc_binaries.py:
##########
@@ -203,7 +203,9 @@ def _download_file(self, dest, asset):
"--header",
"Accept: application/octet-stream",
# Also retry 403s
- "--retry-all-errors",
+ "--retry",
+ "5",
+ "--fail"
Review Comment:
Sure. I changed to check the version, though not 100% confident my method is very portable. I welcome suggestions on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #15099: MINOR: [Release] Support older versions of CURL in GitHub downloader
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #15099:
URL: https://github.com/apache/arrow/pull/15099#issuecomment-1366980803
Benchmark runs are scheduled for baseline = aac30873fd9b112d236a7359fcc8a60f04ebfead and contender = 463cdccdf7a1914073b29f61915018b2045bb429. 463cdccdf7a1914073b29f61915018b2045bb429 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6ccc10b9f2504d2f8afe03b0e1477c1a...93aff0b4448744929ed0143d7d326306/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a75ff58494c54bac84e993d3e1b09b78...81b0a3a853314824a209e31d6159d963/)
[Finished :arrow_down:1.79% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d587f93c794b45148e85ad5196f86304...40a456d8d9b74153a587efc7a459f407/)
[Finished :arrow_down:0.76% :arrow_up:0.14%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a8135a55ff554fa89d2914ce3da94072...f8ee13c9e054493b8d97f626cbfdaf02/)
Buildkite builds:
[Finished] [`463cdccd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2077)
[Failed] [`463cdccd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2099)
[Finished] [`463cdccd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2071)
[Finished] [`463cdccd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2091)
[Finished] [`aac30873` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2076)
[Failed] [`aac30873` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2098)
[Finished] [`aac30873` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2070)
[Finished] [`aac30873` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2090)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org