You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sashapolo (via GitHub)" <gi...@apache.org> on 2024/10/18 11:15:40 UTC
[PR] IGNITE-23491 Fix various issues with the Cluster class [ignite-3]
sashapolo opened a new pull request, #4595:
URL: https://github.com/apache/ignite-3/pull/4595
* Nullify the list of nodes after calling `Cluster#shutdown`
* Use threadsafe collections where necessary
* Cleanup usages of starting and stoppng a cluster
https://issues.apache.org/jira/browse/IGNITE-23491
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23491 Fix various issues with the Cluster class [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #4595:
URL: https://github.com/apache/ignite-3/pull/4595#discussion_r1806458291
##########
modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/authentication/ItAuthenticationTest.java:
##########
@@ -62,9 +62,7 @@ public class ItAuthenticationTest extends ClusterPerTestIntegrationTest {
@BeforeEach
Review Comment:
@Override will be enough for that. Overridden methods without proper annotation shouldn't be started even if parent method has @BeforeAll annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23491 Fix various issues with the Cluster class [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #4595:
URL: https://github.com/apache/ignite-3/pull/4595#discussion_r1806417477
##########
modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/authentication/ItAuthenticationTest.java:
##########
@@ -62,9 +62,7 @@ public class ItAuthenticationTest extends ClusterPerTestIntegrationTest {
@BeforeEach
Review Comment:
We can remove @BeforeEach from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23491 Fix various issues with the Cluster class [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #4595:
URL: https://github.com/apache/ignite-3/pull/4595#discussion_r1806458291
##########
modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/authentication/ItAuthenticationTest.java:
##########
@@ -62,9 +62,7 @@ public class ItAuthenticationTest extends ClusterPerTestIntegrationTest {
@BeforeEach
Review Comment:
Overriden will be enough for that. Overridden methods without proper annotation shouldn't be started even if parent method has @BeforeAll annotation.
##########
modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/authentication/ItAuthenticationTest.java:
##########
@@ -62,9 +62,7 @@ public class ItAuthenticationTest extends ClusterPerTestIntegrationTest {
@BeforeEach
Review Comment:
Override will be enough for that. Overridden methods without proper annotation shouldn't be started even if parent method has @BeforeAll annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23491 Fix various issues with the Cluster class [ignite-3]
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #4595:
URL: https://github.com/apache/ignite-3/pull/4595#discussion_r1806555051
##########
modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/authentication/ItAuthenticationTest.java:
##########
@@ -62,9 +62,7 @@ public class ItAuthenticationTest extends ClusterPerTestIntegrationTest {
@BeforeEach
Review Comment:
ok, I understand what you mean now. Let's leave it as-is, because this is the only comment and I don't want to wait for the TC again just because of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23491 Fix various issues with the Cluster class [ignite-3]
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #4595:
URL: https://github.com/apache/ignite-3/pull/4595#discussion_r1806454918
##########
modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/authentication/ItAuthenticationTest.java:
##########
@@ -62,9 +62,7 @@ public class ItAuthenticationTest extends ClusterPerTestIntegrationTest {
@BeforeEach
Review Comment:
No, it's here on purpose in order to *not* start a cluster at the beginning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23491 Fix various issues with the Cluster class [ignite-3]
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo merged PR #4595:
URL: https://github.com/apache/ignite-3/pull/4595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org