You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/08 15:43:30 UTC

[GitHub] [arrow] nevi-me opened a new pull request #9138: ARROW-11167: [Rust] [Parquet] Pin specific parquet-format-rs version

nevi-me opened a new pull request #9138:
URL: https://github.com/apache/arrow/pull/9138


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756860174


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=h1) Report
   > Merging [#9138](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=desc) (0969097) into [master](https://codecov.io/gh/apache/arrow/commit/98159f18dae0fdccfa967bfc452966a054e41cce?el=desc) (98159f1) will **decrease** coverage by `0.03%`.
   > The diff coverage is `77.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9138/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9138      +/-   ##
   ==========================================
   - Coverage   82.60%   82.57%   -0.04%     
   ==========================================
     Files         204      204              
     Lines       50496    50879     +383     
   ==========================================
   + Hits        41713    42011     +298     
   - Misses       8783     8868      +85     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow-pyarrow-integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy1weWFycm93LWludGVncmF0aW9uLXRlc3Rpbmcvc3JjL2xpYi5ycw==) | `0.00% <ø> (ø)` | |
   | [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `7.02% <ø> (ø)` | |
   | [...datafusion/src/physical\_plan/string\_expressions.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3N0cmluZ19leHByZXNzaW9ucy5ycw==) | `87.50% <ø> (ø)` | |
   | [rust/datafusion/src/optimizer/utils.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvdXRpbHMucnM=) | `58.18% <45.45%> (-0.54%)` | :arrow_down: |
   | [rust/datafusion/src/sql/utils.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvdXRpbHMucnM=) | `53.92% <47.05%> (-0.68%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/functions.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Z1bmN0aW9ucy5ycw==) | `78.51% <63.63%> (-1.49%)` | :arrow_down: |
   | [rust/arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3NvcnQucnM=) | `93.56% <68.62%> (+0.14%)` | :arrow_up: |
   | [rust/datafusion/src/logical\_plan/expr.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vZXhwci5ycw==) | `76.92% <77.27%> (+0.02%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/expressions.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zLnJz) | `83.77% <78.53%> (-0.71%)` | :arrow_down: |
   | [rust/arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZmZpLnJz) | `75.95% <80.00%> (+0.28%)` | :arrow_up: |
   | ... and [10 more](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=footer). Last update [c4ee536...0969097](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554137789



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       yes for sure




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sunchao commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554095087



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       nit: can we add a comment here for future reference? I think this is not the first time we got this error.

##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       Sure. SGTM.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756849020






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me edited a comment on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
nevi-me edited a comment on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756833832


   @alamb the version of the crate follows the Parquet format versioning. I was thinking about it today, I'll open a PR in the crate, suggesting how the versioning can work going forward.
   
   We released `2.7.0`, and we're going to release `2.8.0` soon, to follow the parquet format versions.
   
   We can use `x.y._` to denote the `parquet-format` specification version, and then use `_._.y` for bugfixes on the crate where we don't change the format version, like we did with `2.6.0` and `2.6.1`. CC @sunchao 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756861621


   > BTW, should we check and pin all dependencies in this way to avoid suddenly broking?
   
   Historically, we seldom have issues with minor version of crates being updated. I think the effort to pin everything isn't worth it. It's actually by luck that we caught the parquet-format-rs update before a new major Arrow release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mqy commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756859708


   > > Thanks @nevi-me I guess the reason that I can't reproduce this failure may related to crate cache somehow?
   > 
   > @mqy you can probably reproduce the problem if you run `cargo update` which will force cargo to pull all the latest dependencies
   
   @alamb reproduced, thanks! Here is the output from my local `cargo update`:
   
   ```
       Updating crates.io index
       Updating ahash v0.6.1 -> v0.6.2
       Updating anyhow v1.0.34 -> v1.0.37
       Updating byteorder v1.3.4 -> v1.4.0
       Updating cc v1.0.65 -> v1.0.66
       Updating const_fn v0.4.3 -> v0.4.5
       Updating futures v0.3.8 -> v0.3.9
       Updating futures-channel v0.3.8 -> v0.3.9
       Updating futures-core v0.3.8 -> v0.3.9
       Updating futures-executor v0.3.8 -> v0.3.9
       Updating futures-io v0.3.8 -> v0.3.9
       Updating futures-macro v0.3.8 -> v0.3.9
       Updating futures-sink v0.3.8 -> v0.3.9
       Updating futures-task v0.3.8 -> v0.3.9
       Updating futures-util v0.3.8 -> v0.3.9
       Removing getrandom v0.1.15
       Removing getrandom v0.2.0
         Adding getrandom v0.1.16
         Adding getrandom v0.2.1
       Updating heck v0.3.1 -> v0.3.2
       Updating http v0.2.1 -> v0.2.2
       Updating indexmap v1.6.0 -> v1.6.1
       Updating itoa v0.4.6 -> v0.4.7
       Updating libc v0.2.80 -> v0.2.82
       Updating net2 v0.2.36 -> v0.2.37
       Updating ordered-float v1.1.0 -> v1.1.1
       Updating parquet-format v2.6.1 -> v2.7.0
       Updating paste v1.0.3 -> v1.0.4
       Updating pin-project v1.0.2 -> v1.0.3
       Updating pin-project-internal v1.0.2 -> v1.0.3
       Updating pin-project-lite v0.2.0 -> v0.2.1
       Updating quote v1.0.7 -> v1.0.8
       Updating rand v0.8.0 -> v0.8.1
       Updating rand_core v0.6.0 -> v0.6.1
       Updating regex v1.4.2 -> v1.4.3
       Updating regex-syntax v0.6.21 -> v0.6.22
       Updating serde v1.0.117 -> v1.0.118
       Updating serde_derive v1.0.117 -> v1.0.118
       Updating serde_json v1.0.59 -> v1.0.61
       Updating smallvec v1.5.0 -> v1.6.0
       Updating socket2 v0.3.17 -> v0.3.19
       Updating syn v1.0.53 -> v1.0.58
       Updating thiserror v1.0.22 -> v1.0.23
       Updating thiserror-impl v1.0.22 -> v1.0.23
       Updating thread_local v1.0.1 -> v1.1.0
       Updating time v0.1.44 -> v0.1.43
       Updating tinytemplate v1.1.0 -> v1.2.0
       Updating tokio v0.2.23 -> v0.2.24
       Updating tower-layer v0.3.0 -> v0.3.1
       Updating wasi v0.10.0+wasi-snapshot-preview1 -> v0.10.1+wasi-snapshot-preview1
   ```
   
   BTW, should we check and pin all dependencies in this way to avoid suddenly broking?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb closed pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9138:
URL: https://github.com/apache/arrow/pull/9138


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756833832


   @alamb the version of the crate follows the Parquet format versioning. I was thinking about it today, I'll open a PR in the crate, suggesting how the versioning can work going forward.
   
   We released `2.7.0`, and we're going to release `2.8.0` soon, to follow the parquet format versions.
   
   We can use `x.y._` to denote the `parquet-format` specification version, and then use `_._.y` for bugfixes on that specific version, like we did with `2.6.0` and `2.6.1`. CC @sunchao 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mqy commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
mqy commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554158804



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       The update note was added to https://github.com/apache/arrow/pull/9133/commits/8cf807f8ba1e4a2f769dad8a1b1f63dc725eb34e




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756962524


   >  IMO we should pin the exact version in Cargo.toml
   
   I agree


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756852139


   > Thanks @nevi-me I guess the reason that I can't reproduce this failure may related to crate cache somehow?
   
   @mqy  you can probably reproduce the problem if you run `cargo update` which will force cargo to pull all the latest dependencies


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756956898


   Having a library version be set after a format version is funny, as it is entirely possible to backward incompatibly change an API without backward incompatibly change the format, and vice-versa.
   
   IMO the contract that different implementations sign about a format is independent of the contract that the consumers of a library sign with the developers of the library.
   
   Given the decision to version that package as such, IMO we should pin the exact version in `Cargo.toml`, as there is no guarantee that a minor bump does not break backward compatibility (as this incident shows), and `~` in cargo [assumes semver](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mqy commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756832552






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756860174


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=h1) Report
   > Merging [#9138](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=desc) (0969097) into [master](https://codecov.io/gh/apache/arrow/commit/98159f18dae0fdccfa967bfc452966a054e41cce?el=desc) (98159f1) will **decrease** coverage by `0.03%`.
   > The diff coverage is `77.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9138/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9138      +/-   ##
   ==========================================
   - Coverage   82.60%   82.57%   -0.04%     
   ==========================================
     Files         204      204              
     Lines       50496    50879     +383     
   ==========================================
   + Hits        41713    42011     +298     
   - Misses       8783     8868      +85     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow-pyarrow-integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy1weWFycm93LWludGVncmF0aW9uLXRlc3Rpbmcvc3JjL2xpYi5ycw==) | `0.00% <ø> (ø)` | |
   | [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `7.02% <ø> (ø)` | |
   | [...datafusion/src/physical\_plan/string\_expressions.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3N0cmluZ19leHByZXNzaW9ucy5ycw==) | `87.50% <ø> (ø)` | |
   | [rust/datafusion/src/optimizer/utils.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvdXRpbHMucnM=) | `58.18% <45.45%> (-0.54%)` | :arrow_down: |
   | [rust/datafusion/src/sql/utils.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvdXRpbHMucnM=) | `53.92% <47.05%> (-0.68%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/functions.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Z1bmN0aW9ucy5ycw==) | `78.51% <63.63%> (-1.49%)` | :arrow_down: |
   | [rust/arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3NvcnQucnM=) | `93.56% <68.62%> (+0.14%)` | :arrow_up: |
   | [rust/datafusion/src/logical\_plan/expr.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vZXhwci5ycw==) | `76.92% <77.27%> (+0.02%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/expressions.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zLnJz) | `83.77% <78.53%> (-0.71%)` | :arrow_down: |
   | [rust/arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZmZpLnJz) | `75.95% <80.00%> (+0.28%)` | :arrow_up: |
   | ... and [10 more](https://codecov.io/gh/apache/arrow/pull/9138/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=footer). Last update [c4ee536...0969097](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mqy commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
mqy commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554158804



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       The update note was added to https://github.com/apache/arrow/pull/9133/commits/8cf807f8ba1e4a2f769dad8a1b1f63dc725eb34e




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756831758


   > We had pinned the version at some point, we must have unpinned it while updating dependencies.
   
   I think given that 2.6.1 --> 2.7.0 was a breaking change, the default versioning scheme wanted to see it use major version numbers (aka 2.7.0 should have been 3.0.0)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756831906


   Thanks for fixing this @nevi-me !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554137789



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       yes for sure




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sunchao commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554095087



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       nit: can we add a comment here for future reference? I think this is not the first time we got this error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sunchao commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554122522



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       Sure. SGTM.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb closed pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9138:
URL: https://github.com/apache/arrow/pull/9138


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756870090


   https://issues.apache.org/jira/browse/ARROW-11187


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756829437






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756956898


   Having a library version be set after a format version is funny, as it is entirely possible to backward incompatibly change an API without backward incompatibly change the format, and vice-versa.
   
   IMO the contract that different implementations sign about a format is independent of the contract that the consumers of a library sign with the developers of the library.
   
   Given the decision to version that package as such, IMO we should pin the exact version in `Cargo.toml`, as there is no guarantee that a minor bump does not break backward compatibility (as this incident shows), and `~` in cargo [assumes semver](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756829437


   > I verified that this fixes the build for me locally. I think once the CI completes we should merge it in. Thanks @nevi-me !
   
   We had pinned the version at some point, we must have unpinned it while updating dependencies.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me edited a comment on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
nevi-me edited a comment on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756833832


   @alamb the version of the crate follows the Parquet format versioning. I was thinking about it today, I'll open a PR in the crate, suggesting how the versioning can work going forward.
   
   We released `2.7.0`, and we're going to release `2.8.0` soon, to follow the parquet format versions.
   
   We can use `x.y._` to denote the `parquet-format` specification version, and then use `_._.y` for bugfixes on the crate where we don't change the format version, like we did with `2.6.0` and `2.6.1`. CC @sunchao 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554121387



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       @sunchao @alamb @mqy given the long CI times, is it okay if we piggy-back on #9133 to add the comment?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756849020


   https://issues.apache.org/jira/browse/ARROW-11167


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756831758






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mqy commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756832552


   Thanks @nevi-me I guess the reason that I can't reproduce this failure may related to crate cache somehow?
   Sorry, I did not aware the problem! I had read "2.6.1" as fixed version, that's totally wrong. From https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html, it seems 2.6.* should work as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756887355


   https://issues.apache.org/jira/browse/ARROW-11184


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554121387



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,7 +29,7 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~2.6.1"

Review comment:
       @sunchao @alamb @mqy given the long CI times, is it okay if we piggy-back on #9133 to add the comment?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org