You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/05/13 14:15:24 UTC

Review Request 47346: GEODE-1390: Move gfsh help tests from closed to open

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47346/
-----------------------------------------------------------

Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.


Repository: geode


Description
-------

GEODE-1390: Move gfsh help tests from closed to open


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 0486c5ace90316f9afedb61e78ca59756f630058 
  geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsJUnitTest.java PRE-CREATION 
  geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties PRE-CREATION 
  geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties PRE-CREATION 

Diff: https://reviews.apache.org/r/47346/diff/


Testing
-------


Thanks,

Jens Deppe


Re: Review Request 47346: GEODE-1390: Move gfsh help tests from closed to open

Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47346/#review133124
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On May 13, 2016, 2:15 p.m., Jens Deppe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47346/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 2:15 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1390: Move gfsh help tests from closed to open
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 0486c5ace90316f9afedb61e78ca59756f630058 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsJUnitTest.java PRE-CREATION 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties PRE-CREATION 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47346/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>


Re: Review Request 47346: GEODE-1390: Move gfsh help tests from closed to open

Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47346/#review133148
-----------------------------------------------------------


Ship it!




Ship It!

- Kirk Lund


On May 13, 2016, 2:15 p.m., Jens Deppe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47346/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 2:15 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1390: Move gfsh help tests from closed to open
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 0486c5ace90316f9afedb61e78ca59756f630058 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsJUnitTest.java PRE-CREATION 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties PRE-CREATION 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47346/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>