You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "chandan-khandelwal (via GitHub)" <gi...@apache.org> on 2026/05/29 11:40:21 UTC

[PR] Improved: Prevent potential resource leak in FtpServices.java putFile… [ofbiz-framework]

chandan-khandelwal opened a new pull request, #1300:
URL: https://github.com/apache/ofbiz-framework/pull/1300

   Improved: Prevent potential resource leak in FtpServices.java putFile/getFile (OFBIZ-13427)
   
   We refactored putFile and getFile in FtpServices.java to use try-with-resources, ensuring local file streams are always closed automatically to prevent file descriptor leaks.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: Prevent potential resource leak in FtpServices.java putFile/getFile (OFBIZ-13427) [ofbiz-framework]

Posted by "chandan-khandelwal (via GitHub)" <gi...@apache.org>.
chandan-khandelwal commented on PR #1300:
URL: https://github.com/apache/ofbiz-framework/pull/1300#issuecomment-4591127482

   Yes @nmalin the pull request is ready to merge.
   
   The code now properly closes the resource, so this should address the reported resource leak issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: Prevent potential resource leak in FtpServices.java putFile/getFile (OFBIZ-13427) [ofbiz-framework]

Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin merged PR #1300:
URL: https://github.com/apache/ofbiz-framework/pull/1300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: Prevent potential resource leak in FtpServices.java putFile/getFile (OFBIZ-13427) [ofbiz-framework]

Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on PR #1300:
URL: https://github.com/apache/ofbiz-framework/pull/1300#issuecomment-4591094187

   Hello @chandan-khandelwal, you pull request is ready to merge ?
   
   I looked that you change the try/catch block declaration, is enough escape the resource leak ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org