You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2007/08/10 17:31:11 UTC
DO NOT REPLY [Bug 43089] New: - [PATCH] PDFRenderer - text-decoration (e.g. underline) not being renderered with Type1 fonts
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43089>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43089
Summary: [PATCH] PDFRenderer - text-decoration (e.g. underline)
not being renderered with Type1 fonts
Product: Fop
Version: 1.0dev
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P1
Component: fonts
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: dev@cumiskey.com
I'm a little surprised that no-one hasn't come across this bug sooner, but I
managed to verify its existence and provide a patch that seems to fix the
problem. I guess its not been discovered because most PDF renderer users must
favour using truetype fonts.
A positive descender value was being used on type 1 fonts when calculating the
line width for text-decoration(s). This was causing a negative line width,
resulting in the decoration line not being drawn by the PDF renderer. This
patch fixes this problem. I have successfully tested the patch against a
reasonably complex FO example with both the postscript and pdf renderer to try
and ensure it does not break anything. You can just as easily reproduce the
problem with a simple "hello world!" fo example with a single block (using
text-decoration, referencing a type 1 font-family).
Ideally it would be nice to have a JUnit test case to verify this fix against
but I'm not sure about legal licensing issues with acquiring some free (GPL)
type 1 fonts.
Adrian.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43089] - [PATCH] PDFRenderer - text-decoration (e.g. underline) not being renderered with Type1 fonts
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43089>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43089
------- Additional Comments From dev@cumiskey.com 2007-08-10 08:34 -------
Created an attachment (id=20639)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20639&action=view)
patch file
* Improves error log output in PDFRender.drawBorderLine().
* Fixes descender calculation used from PFMFile.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 43089] - [PATCH] PDFRenderer - text-decoration (e.g. underline) not being renderered with Type1 fonts
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43089>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43089
bowditch_chris@hotmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From bowditch_chris@hotmail.com 2007-08-17 09:07 -------
Patch Applied. Excellent work Adrian!
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.