You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@chukwa.apache.org by as...@apache.org on 2009/03/27 18:58:52 UTC
svn commit: r759291 - in /hadoop/chukwa/trunk: CHANGES.txt
src/java/org/apache/hadoop/chukwa/datacollection/writer/Dedup.java
src/java/org/apache/hadoop/chukwa/datacollection/writer/PipelineStageWriter.java
Author: asrabkin
Date: Fri Mar 27 17:58:51 2009
New Revision: 759291
URL: http://svn.apache.org/viewvc?rev=759291&view=rev
Log:
CHUKWA-48. Resolve some compiler warnings.
Modified:
hadoop/chukwa/trunk/CHANGES.txt
hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/Dedup.java
hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/PipelineStageWriter.java
Modified: hadoop/chukwa/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/chukwa/trunk/CHANGES.txt?rev=759291&r1=759290&r2=759291&view=diff
==============================================================================
--- hadoop/chukwa/trunk/CHANGES.txt (original)
+++ hadoop/chukwa/trunk/CHANGES.txt Fri Mar 27 17:58:51 2009
@@ -35,6 +35,8 @@
BUG FIXES
+ CHUKWA-48. Cleanup code to resolve compiler warnings. (asrabkin)
+
CHUKWA-9. MetricDataLoader should close JDBC connection. (Jerome Boulon via asrabkin)
CHUKWA-37. Remove ChuckwaArchiveBuilder. (asrabkin)
Modified: hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/Dedup.java
URL: http://svn.apache.org/viewvc/hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/Dedup.java?rev=759291&r1=759290&r2=759291&view=diff
==============================================================================
--- hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/Dedup.java (original)
+++ hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/Dedup.java Fri Mar 27 17:58:51 2009
@@ -89,9 +89,6 @@
return b;
}
- private long dupCount() {
- return dupchunks;
- }
}
FixedSizeCache<DedupKey> cache;
Modified: hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/PipelineStageWriter.java
URL: http://svn.apache.org/viewvc/hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/PipelineStageWriter.java?rev=759291&r1=759290&r2=759291&view=diff
==============================================================================
--- hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/PipelineStageWriter.java (original)
+++ hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/writer/PipelineStageWriter.java Fri Mar 27 17:58:51 2009
@@ -46,8 +46,7 @@
String pipeline = conf.get("chukwaCollector.pipeline");
try {
String[] classes = pipeline.split(",");
- ArrayList<PipelineableWriter> stages = new ArrayList<PipelineableWriter>();
-
+ log.info("using pipelined writers, pipe length is " + classes.length);
PipelineableWriter lastWriter = null;
if (classes.length > 1) {
lastWriter = (PipelineableWriter) conf.getClassByName(classes[0])
@@ -57,7 +56,7 @@
}
for (int i = 1; i < classes.length - 1; ++i) {
- Class stageClass = conf.getClassByName(classes[i]);
+ Class<?> stageClass = conf.getClassByName(classes[i]);
Object st = stageClass.newInstance();
if (!(st instanceof PipelineableWriter))
log.error("class " + classes[i]
@@ -72,7 +71,7 @@
lastWriter.setNextStage(stage);
lastWriter = stage;
}
- Class stageClass = conf.getClassByName(classes[classes.length - 1]);
+ Class<?> stageClass = conf.getClassByName(classes[classes.length - 1]);
Object st = stageClass.newInstance();
if (!(st instanceof ChukwaWriter)) {