[GitHub] [ozone] neils-dev commented on pull request #2183: HDDS-5099. Error with unit test for hdds.container-service TestSchemaOneBackwardsCompatibility

[GitBox <gi...@apache.org>]

neils-dev commented on pull request #2183:
URL: https://github.com/apache/ozone/pull/2183#issuecomment-827046293


   > Since we have found the root cause of the intermittent exception in this case, can we simply wait a while before `future.get` in `BlockDeletingServiceTestImpl$start"?
   
   Thanks @symious - true, a delay in BlockDeleteingServiceTestImpl may work provided the delay is sufficient for the workers to complete the tasks; we can choose 10 - 200 ms however this value would vary from platform to platform.  Here we have the thread executor dispatch the completion futures and return when the worker threads are finished, ensuring that the results are available regardless of the platform/environment we are running on.  Another implementation can be through a latch and releasing the caller one the workers have finished, however that would require implementing the counter creating  the same behavior as the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org