You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/21 05:58:58 UTC
[GitHub] [superset] villebro commented on a diff in pull request #19790: chore: bump postgres from 10 to 14
villebro commented on code in PR #19790:
URL: https://github.com/apache/superset/pull/19790#discussion_r854805473
##########
docs/docs/installation/configuring-superset.mdx:
##########
@@ -69,6 +69,32 @@ you can add the endpoints to `WTF_CSRF_EXEMPT_LIST`:
WTF_CSRF_EXEMPT_LIST = [‘’]
```
+### Using a production metadata database
+
+By default Superset is configured to use SQLite, it's a simple and fast way to get you started
+(no installation needed) but for production environments you should use a different database engine on
+a separate host or container.
Review Comment:
Maybe we could split this up into two sentences:
```suggestion
By default Superset is configured to use SQLite, it's a simple and fast way to get you started
(no installation needed). But for production environments you should use a different database engine on
a separate host or container.
```
##########
docs/docs/installation/configuring-superset.mdx:
##########
@@ -69,6 +69,32 @@ you can add the endpoints to `WTF_CSRF_EXEMPT_LIST`:
WTF_CSRF_EXEMPT_LIST = [‘’]
```
+### Using a production metadata database
Review Comment:
We've started to prefer the term "metastore", as "metadata database" is a bit of a tongue twister. But we can do a full update of that in a follow-up PR.
##########
docs/docs/installation/configuring-superset.mdx:
##########
@@ -69,6 +69,32 @@ you can add the endpoints to `WTF_CSRF_EXEMPT_LIST`:
WTF_CSRF_EXEMPT_LIST = [‘’]
```
+### Using a production metadata database
+
+By default Superset is configured to use SQLite, it's a simple and fast way to get you started
+(no installation needed) but for production environments you should use a different database engine on
+a separate host or container.
+
+Superset supports the following database engines/versions:
+
+| Database Engine | Supported Versions |
+| --------------------------------------------------------- | --------------------------------- |
+| [MySQL](https://www.mysql.com/) | 5.X |
+| [PostgreSQL](https://www.postgresql.org/) | 10.X, 11.X, 12.X, 13.X, 14.X |
Review Comment:
Could we kinda recommend using Postgres by placing it on top in the list? Or maybe even explicitly recommend it?
```suggestion
Superset supports the following database engines/versions:
| Database Engine | Supported Versions |
| --------------------------------------------------------- | --------------------------------- |
| [PostgreSQL](https://www.postgresql.org/) | 10.X, 11.X, 12.X, 13.X, 14.X |
| [MySQL](https://www.mysql.com/) | 5.X |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org