You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jihoon Son <ji...@apache.org> on 2014/03/08 06:52:54 UTC
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParser
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/
-----------------------------------------------------------
(Updated March 8, 2014, 2:52 p.m.)
Review request for Tajo.
Summary (updated)
-----------------
TAJO-612: Missing INET4 type in SQLParser
Repository: tajo
Description
-------
See the title. SQLParser cannot parse the INET4 type.
I fixed the problem of parser and some missing codes for processing of INET4 type.
I also added two functions of country() and in_country() for INET4 type.
Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
Diffs
-----
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/CountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
Diff: https://reviews.apache.org/r/18843/diff/
Testing
-------
mvn verify
Thanks,
Jihoon Son
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParser
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/#review36750
-----------------------------------------------------------
+1
It's really nice work. Ship it!
- Hyunsik Choi
On March 10, 2014, 10:27 p.m., Jihoon Son wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18843/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 10:27 p.m.)
>
>
> Review request for Tajo.
>
>
> Repository: tajo
>
>
> Description
> -------
>
> See the title. SQLParser cannot parse the INET4 type.
> I fixed the problem of parser and some missing codes for processing of INET4 type.
> I also added two functions of country() and in_country() for INET4 type.
> Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
>
>
> Diffs
> -----
>
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPInCountryInet4.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPInCountryText.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/GeoIPUtil.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/GeoUtil.java 6028725
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
> tajo-docs/src/main/sphinx/functions.rst e021f00
> tajo-docs/src/main/sphinx/functions/network_func_and_operators.rst PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18843/diff/
>
>
> Testing
> -------
>
> mvn verify
>
>
> Thanks,
>
> Jihoon Son
>
>
Re: Review Request 18843: TAJO-612: Missing INET4 type in SQLParser
Posted by Jihoon Son <ji...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18843/
-----------------------------------------------------------
(Updated March 10, 2014, 10:27 p.m.)
Review request for Tajo.
Changes
-------
I reflected Hyunsik's comments.
Repository: tajo
Description
-------
See the title. SQLParser cannot parse the INET4 type.
I fixed the problem of parser and some missing codes for processing of INET4 type.
I also added two functions of country() and in_country() for INET4 type.
Lastly, I added the TestNetTypes class to verify the query processing of INET4 type.
Diffs (updated)
-----
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 db04d4b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/Country.java 9e28b55
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/InCountry.java 1cac624
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPInCountryInet4.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPInCountryText.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 29e4d43
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java 358cabd
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java 5bff857
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/GeoIPUtil.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/GeoUtil.java 6028725
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table1.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testGroupby2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testJoin.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSelect.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testGroupby2.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSelect.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort.result PRE-CREATION
tajo-docs/src/main/sphinx/functions.rst e021f00
tajo-docs/src/main/sphinx/functions/network_func_and_operators.rst PRE-CREATION
Diff: https://reviews.apache.org/r/18843/diff/
Testing
-------
mvn verify
Thanks,
Jihoon Son