You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "celeste-zeng (via GitHub)" <gi...@apache.org> on 2023/08/04 23:21:50 UTC
[GitHub] [beam] celeste-zeng opened a new pull request, #27863: Add setup Java for different Java versions.
celeste-zeng opened a new pull request, #27863:
URL: https://github.com/apache/beam/pull/27863
- Add an extra step for to set up different versions of Java.
- Added extra flags to the gradle task by following other Java tests.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #27863: Add setup Java for different Java versions.
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #27863:
URL: https://github.com/apache/beam/pull/27863#discussion_r1284909156
##########
.github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml:
##########
@@ -115,6 +120,9 @@ jobs:
-Ppush-containers \
-Pdocker-repository-root=us.gcr.io/apache-beam-testing/github-actions \
-Pdocker-tag=${{env.TAG}} \
+ -PdisableSpotlessCheck=true \
+ -PdisableCheckStyle=true \
+ -PskipCheckerFramework \
Review Comment:
do we have these flags elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] celeste-zeng commented on a diff in pull request #27863: Add setup Java for different Java versions.
Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on code in PR #27863:
URL: https://github.com/apache/beam/pull/27863#discussion_r1284911021
##########
.github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml:
##########
@@ -115,6 +120,9 @@ jobs:
-Ppush-containers \
-Pdocker-repository-root=us.gcr.io/apache-beam-testing/github-actions \
-Pdocker-tag=${{env.TAG}} \
+ -PdisableSpotlessCheck=true \
+ -PdisableCheckStyle=true \
+ -PskipCheckerFramework \
Review Comment:
reference:https://github.com/celeste-zeng/beam/blob/e3d321bc54dca8d258c843566db792cb60967c05/.test-infra/jenkins/job_PostCommit_Java_Examples_Dataflow_V2_Java17.groovy#L47 and here https://github.com/apache/beam/blob/8bd2c97351a4e6f8c6bafd260265d3ca2b7e3673/.github/workflows/beam_PreCommit_Java_Examples_Dataflow_Java11.yml#L105C14-L105C35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27863: Add setup Java for different Java versions.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27863:
URL: https://github.com/apache/beam/pull/27863#issuecomment-1666286243
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #27863: Add setup Java for different Java versions.
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #27863:
URL: https://github.com/apache/beam/pull/27863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org