You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by ericcarlschwartz <gi...@git.apache.org> on 2015/09/14 20:21:42 UTC
[GitHub] trafficserver pull request: [TS-3911] Create log tag for server co...
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/293
[TS-3911] Create log tag for server connection isSSL
Have tested this and provides the correct info.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericcarlschwartz/trafficserver TS-3911
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit d861ea1031248361a9992efa9e0cb3b8fe2af86c
Author: ericcarlschwartz <es...@gmail.com>
Date: 2015-09-14T18:04:10Z
[TS-3911] Create log tag for server connection isSSL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-3911] Create log tag for whether p...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/293#discussion_r39430575
--- Diff: proxy/logging/Log.cc ---
@@ -478,7 +478,7 @@ Log::init_fields()
global_field_list.add(field, false);
ink_hash_table_insert(field_symbol_hash, "cqtr", field);
- field = new LogField("client_req_ssl_reused", "cqssl", LogField::dINT, &LogAccess::marshal_client_req_is_ssl,
+ field = new LogField("client_req_is_ssl", "cqssl", LogField::dINT, &LogAccess::marshal_client_req_is_ssl,
--- End diff --
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-3911] Create log tag for whether p...
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/293#discussion_r39430482
--- Diff: proxy/logging/Log.cc ---
@@ -478,7 +478,7 @@ Log::init_fields()
global_field_list.add(field, false);
ink_hash_table_insert(field_symbol_hash, "cqtr", field);
- field = new LogField("client_req_ssl_reused", "cqssl", LogField::dINT, &LogAccess::marshal_client_req_is_ssl,
+ field = new LogField("client_req_is_ssl", "cqssl", LogField::dINT, &LogAccess::marshal_client_req_is_ssl,
--- End diff --
@zwoop this look good?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-3911] New log tag for proxy connec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-3911] Create log tag for server co...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/293#issuecomment-140170568
As discussed on the IRC, I think we should
1) Change the subject for this Jira, I thought isSSL was the name of the new tag.
2) The description should change, instead of "proxy_req_ssl_reused" it should be e.g. "proxy_req_is_ssl"
#2 is a bug in a previous patch, so we should fix that as well, for the "cqssl" tag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---