[GitHub] [maven] mthmulders commented on a diff in pull request #1137: [MNG-7604] Removal of pom.* interpolation makes some older plugins defunct

["mthmulders (via GitHub)" <gi...@apache.org>]

mthmulders commented on code in PR #1137:
URL: https://github.com/apache/maven/pull/1137#discussion_r1213587809


##########
maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingRequest.java:
##########
@@ -57,10 +57,15 @@ public interface ModelBuildingRequest {
      */
     int VALIDATION_LEVEL_MAVEN_3_1 = 31;
 
+    /**
+     * Denotes validation as performed by Maven 3.1. This validation level is meant for new projects.

Review Comment:
   ```suggestion
        * Denotes validation as performed by Maven 4.0. This validation level is meant for new projects.
   ```



##########
maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingRequest.java:
##########
@@ -57,10 +57,15 @@ public interface ModelBuildingRequest {
      */
     int VALIDATION_LEVEL_MAVEN_3_1 = 31;
 
+    /**
+     * Denotes validation as performed by Maven 3.1. This validation level is meant for new projects.

Review Comment:
   Also, for `VALIDATION_LEVEL_MAVEN_3_1` I think the Javadoc should now read "This validation level is meant for existing projects."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org