You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/10/03 23:15:33 UTC
Review Request 62761: Moved retry logic from RecoverProtocolProcess to
RecoverProcess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62761/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-7973
https://issues.apache.org/jira/browse/MESOS-7973
Repository: mesos
Description
-------
Moved retry logic from RecoverProtocolProcess to RecoverProcess.
Diffs
-----
src/log/recover.hpp 94d6bb283ea82df607fcc72de05cda3b12ad5d2d
src/log/recover.cpp b366818767adb259ee6805f9978fd330b790a264
src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396
Diff: https://reviews.apache.org/r/62761/diff/1/
Testing
-------
Added a test that verifies that retry logic is working in `recover()`. Ran `make check`.
Thanks,
Ilya Pronin
Re: Review Request 62761: Moved retry logic from
RecoverProtocolProcess to RecoverProcess.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62761/#review194369
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Oct. 3, 2017, 11:15 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62761/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2017, 11:15 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7973
> https://issues.apache.org/jira/browse/MESOS-7973
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved retry logic from RecoverProtocolProcess to RecoverProcess.
>
>
> Diffs
> -----
>
> src/log/recover.hpp 94d6bb283ea82df607fcc72de05cda3b12ad5d2d
> src/log/recover.cpp b366818767adb259ee6805f9978fd330b790a264
> src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396
>
>
> Diff: https://reviews.apache.org/r/62761/diff/1/
>
>
> Testing
> -------
>
> Added a test that verifies that retry logic is working in `recover()`. Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>