You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/20 05:48:41 UTC

[GitHub] [apisix] spacewander commented on a diff in pull request #7946: test: fix config error in test cases

spacewander commented on code in PR #7946:
URL: https://github.com/apache/apisix/pull/7946#discussion_r974908599


##########
t/tars/discovery/tars.t:
##########
@@ -41,8 +41,8 @@ discovery:
       database: db_tars
       user: root
       password: tars2022
-    full_fetch_interval: 3
-    incremental_fetch_interval: 1
+    full_fetch_interval: 90

Review Comment:
   > The APISIX will fail before modify the schema, maybe we should figure out another way to reduce the interval.
   
   @monkeyDluffy6017 
   Interesting. The modification is done in the init_by_lua phase. It is strange that the schema validation happens before it. Could you dig deeper into it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org