You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ma...@apache.org on 2026/02/16 08:49:59 UTC
(cordova-plugin-inappbrowser) branch master updated: refactor(ios)!: remove property `instance` and getter method `getInstance` (#1116)
This is an automated email from the ASF dual-hosted git repository.
manuelbeck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git
The following commit(s) were added to refs/heads/master by this push:
new c5a0979 refactor(ios)!: remove property `instance` and getter method `getInstance` (#1116)
c5a0979 is described below
commit c5a09799f12a5df7fed164b2cae9565d708accba
Author: Manuel Beck <ma...@outlook.de>
AuthorDate: Mon Feb 16 09:49:55 2026 +0100
refactor(ios)!: remove property `instance` and getter method `getInstance` (#1116)
- This was used when WKWebView was added and optional besides UIWebView:
https://github.com/apache/cordova-plugin-inappbrowser/commit/dc7fa34bbe08cf521ac01f603dace16a17091bff
- Since `instance` and `getInstance` were public, this is a breaking change
---
src/ios/CDVWKInAppBrowser.h | 2 --
src/ios/CDVWKInAppBrowser.m | 8 --------
2 files changed, 10 deletions(-)
diff --git a/src/ios/CDVWKInAppBrowser.h b/src/ios/CDVWKInAppBrowser.h
index 4755b2d..a2f0b95 100644
--- a/src/ios/CDVWKInAppBrowser.h
+++ b/src/ios/CDVWKInAppBrowser.h
@@ -42,11 +42,9 @@ typedef NSDictionary CDVSettingsDictionary;
BOOL _waitForBeforeload;
}
-@property (nonatomic, retain) CDVWKInAppBrowser *instance;
@property (nonatomic, retain) CDVWKInAppBrowserViewController *inAppBrowserViewController;
@property (nonatomic, copy) NSString *callbackId;
-+ (id) getInstance;
- (void)open:(CDVInvokedUrlCommand *)command;
- (void)close:(CDVInvokedUrlCommand *)command;
- (void)injectScriptCode:(CDVInvokedUrlCommand *)command;
diff --git a/src/ios/CDVWKInAppBrowser.m b/src/ios/CDVWKInAppBrowser.m
index 6fa25a8..4a5b28f 100644
--- a/src/ios/CDVWKInAppBrowser.m
+++ b/src/ios/CDVWKInAppBrowser.m
@@ -34,16 +34,8 @@
@implementation CDVWKInAppBrowser
-static CDVWKInAppBrowser *instance = nil;
-
-+ (id)getInstance
-{
- return instance;
-}
-
- (void)pluginInitialize
{
- instance = self;
_beforeload = @"";
_waitForBeforeload = NO;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org